[GitHub] [arrow] nealrichardson commented on pull request #7660: ARROW-9291 [R]: Support fixed size binary/list types

[GitBox <gi...@apache.org>]

nealrichardson commented on pull request #7660:
URL: https://github.com/apache/arrow/pull/7660#issuecomment-655054010


   Let me see if I understand the issues you're concerned with. We have some inconsistency in how types are converted: `raw` -> `uint8`, but `uint8` -> `integer`, for example. Here, `binary` -> `list_of(raw)`, and we've special-cased `list_of(raw)` -> `binary`, but you might think that it should be `list_of(uint8)` given how the non-list type is converted. 
   
   I'm fine with getting rid of the special-casing of `list_of(raw)` to `binary` and having the binary conversion set an R class (subclass of vctrs list of or whatever), which we use to determine that the list of raw should be converted back to BinaryArray. I'm not particularly worried that someone would have a list of raw vectors in R and be frustrated that that wasn't converted to a list of uint8--seems unlikely, and if you really care, you can always specify a type/schema. But it seems reasonable to be explicit and set a class attribute.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org