[GitHub] ThomasDelteil commented on a change in pull request #11254: add blocklist

[GitBox <gi...@apache.org>]

ThomasDelteil commented on a change in pull request #11254: add blocklist
URL: https://github.com/apache/incubator-mxnet/pull/11254#discussion_r195174456
 
 

 ##########
 File path: python/mxnet/gluon/block.py
 ##########
 @@ -841,6 +842,140 @@ def hybrid_forward(self, F, x, *args, **kwargs):
         # pylint: disable= invalid-name
         raise NotImplementedError
 
+
+class BlockList(Block):
+    r"""Holds sub-blocks in a list.
+
+    BlockList can be indexed like a regular Python list, but blocks it
+    contains are properly registered, and will be visible by all Block methods::
 
 Review comment:
   what does it mean to be "properly" registered? Can a block be improperly registered?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services