[jira] [Commented] (GEODE-8918) Geode replication event forwarding does not honor GW sender state

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279699#comment-17279699 ] 

ASF GitHub Bot commented on GEODE-8918:
---------------------------------------

mkevo opened a new pull request #6008:
URL: https://github.com/apache/geode/pull/6008


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Geode replication event forwarding does not honor GW sender state
> -----------------------------------------------------------------
>
>                 Key: GEODE-8918
>                 URL: https://issues.apache.org/jira/browse/GEODE-8918
>             Project: Geode
>          Issue Type: Bug
>          Components: wan
>            Reporter: Mario Kevo
>            Assignee: Mario Kevo
>            Priority: Major
>
> {color:#172b4d}With 3+ geo-red systems Geode replication has the forwarding feature which means that receiving cluster will forward the event it just got to all clusters it is connected to that have not yet received the event.{color}
> {color:#172b4d}This is possible because the originating cluster is setting metadata in the replication event like this:
> GatewaySenderEventCallbackArgument [originalCallbackArg=null;originatingSenderId=1;recipientGatewayReceivers= {color}{color:#172b4d}{3, 2}{color}{color:#172b4d}]
>  
> Site receiving this event thus knows which is the originating site and which sites should have received this event. All others will have this event forwarded to. All this is legacy Geode behavior.
>  
> However, originating site does not care if GW sender to a destination is stopped or not - only the fact GW sender is *created and attached* to a region is enough. This means if e.g. GW sender from Site1 to Site 3 is stopped (and has been stopped for a while - so this has nothing to do with timing) at the moment an event hits the replication it is only going to be sent to Site 2 *but with the same metadata*_._ Hence Site 2 will not forward to Site 3 (assuming it has a connection to it).{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)