You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/04/13 17:51:32 UTC
[GitHub] [cassandra-in-jvm-dtest-api] jonmeredith commented on issue #7:
CASSANDRA-15713 made shared class filter for InstanceClassLoader pluggable
jonmeredith commented on issue #7: CASSANDRA-15713 made shared class filter for InstanceClassLoader pluggable
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/7#issuecomment-613012239
Looks like I don't have permissions to do a 'GitHub Review', so I'll leave it here.
Updated #8 to use this mechanism instead of hard-coding `org.w3c.dom` and it worked nicely.
+1 with a minor formatting nit that `sharePackage` changed length when renamed `DEFAULT_SHARED_PACKAGES` and now the list is no longer aligned, though the current alignment is fairly horrible starting 55+ characters in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org