You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/10/24 09:45:02 UTC

[GitHub] [mynewt-nimble] prasad-alatkar opened a new pull request #625: NimBLE host: Avoid calling stop before initializing `ble_hs_flow_timer` in `ble_hs_flow_startup`

prasad-alatkar opened a new pull request #625: NimBLE host: Avoid calling stop before initializing `ble_hs_flow_timer` in `ble_hs_flow_startup`
URL: https://github.com/apache/mynewt-nimble/pull/625
 
 
   In `ble_hs_flow_startup`, stop `ble_hs_flow_timer` is called before creating it.
   This results in accessing invalid/null `TimerHandle`. IMHO ideal solution could have been checking for invalid `co->handle` in `ble_npl_callout_stop` (NPL `nimble_npl_os.h`). But as discussed in [PR!279](https://github.com/apache/mynewt-nimble/pull/279), I have followed similar solution here as well. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services