[GitHub] [solr] KennyKnecht commented on a change in pull request #236: SOLR-15546: ShortestPathStream to handle ids with colons.

[GitBox <gi...@apache.org>]

KennyKnecht commented on a change in pull request #236:
URL: https://github.com/apache/solr/pull/236#discussion_r679059202



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/graph/ShortestPathStream.java
##########
@@ -433,7 +433,7 @@ public JoinRunner(List<String> nodes) {
       StringBuffer nodeQuery = new StringBuffer();
 
       for(String node : nodes) {
-        nodeQuery.append(node).append(" ");
+        nodeQuery.append('"').append(node).append('"').append(" ");

Review comment:
       Good remark




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org