You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "paultmathew (via GitHub)" <gi...@apache.org> on 2026/05/05 17:42:49 UTC

[PR] fix(hitl): show mapped task instances on /required_actions listing [airflow]

paultmathew opened a new pull request, #66433:
URL: https://github.com/apache/airflow/pull/66433

   Fixes #66428.
   
   ## Why
   
   `/required_actions` and the per-DAG / per-Run / per-Task Required Actions
   tabs all silently dropped HITL rows for mapped task instances because the
   listing component hard-coded `mapIndex: parseInt(searchParams.get(MAP_INDEX) ?? "-1", 10)`,
   which always sent `map_index=-1` and filtered to non-mapped TIs only.
   Issue #66428 has the full repro and access-log evidence.
   
   ## What
   
   * Pass `mapIndex` to the listing call only when the user has explicitly
     set the `map_index` URL search param. Default behaviour is now
     "all map indexes" (no filter) instead of "non-mapped only", and
     `map_index=-1` continues to work as an opt-in filter for non-mapped
     task instances.
   * Fix the auto-refresh predicate that compared
     `responded_at === undefined` instead of `=== null`. The API serializes
     `responded_at` as JSON `null`, never an omitted field, so the predicate
     never matched and the page never polled for new pending actions while
     open. The issue's "Anything else" section flagged this; the OP offered
     to roll it into the same PR and there has been no maintainer pushback,
     so it is included here.
   
   ## Tests
   
   * Added `HITLTaskInstances.test.tsx` covering the three URL-param
     branches (`map_index` absent / set to `2` / set to `-1`) and the
     refetch predicate for both `responded_at: null` and a populated value.
   * Locally verified with `pnpm exec vitest run src/pages/HITLTaskInstances/HITLTaskInstances.test.tsx`
     (5/5 passing), `pnpm exec eslint src/pages/HITLTaskInstances/`,
     `pnpm exec tsc -p tsconfig.app.json --noEmit`, and `prek run --files`
     on the changed files.
   
   <!-- Please keep an empty line for the release notes feature to work properly. -->
   ^ Add meaningful description above
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines) for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   
   Made with [Cursor](https://cursor.com)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(hitl): show mapped task instances on /required_actions listing [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #66433:
URL: https://github.com/apache/airflow/pull/66433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(hitl): show mapped task instances on /required_actions listing [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #66433:
URL: https://github.com/apache/airflow/pull/66433#issuecomment-4389718408

   ### Backport successfully created: v3-2-test
   
   Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
   the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
   
   In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
   
   <table>
           <tr>
           <th>Status</th>
           <th>Branch</th>
           <th>Result</th>
       </tr>
       <tr>
           <td>✅</td>
           <td>v3-2-test</td>
           <td><a href="https://github.com/apache/airflow/pull/66482"><img src="https://img.shields.io/badge/PR-66482-blue" alt="PR Link"></a></td>
       </tr>
   </table>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(hitl): show mapped task instances on /required_actions listing [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #66433:
URL: https://github.com/apache/airflow/pull/66433#issuecomment-4389700657

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(hitl): show mapped task instances on /required_actions listing [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #66433:
URL: https://github.com/apache/airflow/pull/66433#issuecomment-4381638750

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org