You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/12/14 18:27:15 UTC
Review Request 64618: Implemented the master's
ACKNOWLEDGE_OFFER_OPERATION_UPDATE handler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description
-------
Implemented the master's ACKNOWLEDGE_OFFER_OPERATION_UPDATE handler.
Diffs
-----
src/master/master.cpp e082da8267fa22c26818c67bd6da573fe1808696
src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491
src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba
Diff: https://reviews.apache.org/r/64618/diff/1/
Testing
-------
Thanks,
Gaston Kleiman
Re: Review Request 64618: Implemented the master's
ACKNOWLEDGE_OFFER_OPERATION_UPDATE handler.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review193826
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['64618']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-build-cmake-stdout.log):
```
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\master.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\quota_handler.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(6314): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(6416): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(6981): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(9105): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(10946): warning C4244: 'return': conversion from '::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\allocator\sorter\drf\sorter.cpp(589): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\weights_handler.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) ->
D:\DCOS\mesos\mesos\src\master\master.cpp(5897): error C2039: 'fromBytes': is not a member of 'mesos::UUID' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(5897): error C3861: 'fromBytes': identifier not found [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(5897): error C2228: left of '.get' must have class/struct/union [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(5934): error C2440: 'initializing': cannot convert from 'Option<T>' to 'Option<mesos::UUID>' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(5945): error C2664: 'mesos::OfferOperation *mesos::internal::master::Slave::getOfferOperation(const id::UUID &) const': cannot convert argument 1 from 'const mesos::UUID' to 'const id::UUID &' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(5961): error C2039: 'set_status_uuid': is not a member of 'mesos::internal::OfferOperationUpdateAcknowledgementMessage' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(5961): error C2039: 'toBytes': is not a member of 'mesos::UUID' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(5962): error C2039: 'set_operation_uuid': is not a member of 'mesos::internal::OfferOperationUpdateAcknowledgementMessage' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(5962): error C2039: 'toBytes': is not a member of 'mesos::UUID' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(5978): error C2039: 'toBytes': is not a member of 'mesos::UUID' [D:\DCOS\mesos\src\mesos.vcxproj]
135 Warning(s)
10 Error(s)
Time Elapsed 00:02:27.55
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "cmTC_2a160.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_2a160.dir\Debug\cmTC_2a160.tlog\".
InitializeBuildStatus:
Creating "cmTC_2a160.dir\Debug\cmTC_2a160.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_2a160.dir\Debug\" /Fd"cmTC_2a160.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_2a160.dir\Debug\" /Fd"cmTC_2a160.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_2a160.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2a160.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2a160.lib" /MACHINE:X64 /machine:x64 cmTC_2a160.dir\Debug\src.obj
cmTC_2a160.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_2a160.exe
FinalizeBuildStatus:
Deleting file "cmTC_2a160.dir\Debug\cmTC_2a160.tlog\unsuccessfulbuild".
Touching "cmTC_2a160.dir\Debug\cmTC_2a160.tlog\cmTC_2a160.lastbuildstate".
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_2a160.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:00.99
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_1451b.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_1451b.dir\Debug\cmTC_1451b.tlog\".
InitializeBuildStatus:
Creating "cmTC_1451b.dir\Debug\cmTC_1451b.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_1451b.dir\Debug\" /Fd"cmTC_1451b.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_1451b.dir\Debug\" /Fd"cmTC_1451b.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_1451b.vcxproj]
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_1451b.vcxproj" (default targets) -- FAILED.
Build FAILED.
"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_1451b.vcxproj" (default target) (1) ->
(ClCompile target) ->
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_1451b.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:00.57
```
- Mesos Reviewbot Windows
On Dec. 14, 2017, 6:27 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 6:27 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's ACKNOWLEDGE_OFFER_OPERATION_UPDATE handler.
>
>
> Diffs
> -----
>
> src/master/master.cpp e082da8267fa22c26818c67bd6da573fe1808696
> src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491
> src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba
>
>
> Diff: https://reviews.apache.org/r/64618/diff/1/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196082
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['65300', '64618']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-build-cmake-stdout.log):
```
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _strdup. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(289): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(290): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(293): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(138): warning C4477: 'snprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 1 has type 'time_t' [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(157): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(293): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) ->
D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C2039: 'eraseenv': is not a member of 'os' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C3861: 'eraseenv': identifier not found [D:\DCOS\mesos\src\mesos.vcxproj]
112 Warning(s)
2 Error(s)
Time Elapsed 00:03:23.53
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "cmTC_8dfe1.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_8dfe1.dir\Debug\cmTC_8dfe1.tlog\".
InitializeBuildStatus:
Creating "cmTC_8dfe1.dir\Debug\cmTC_8dfe1.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_8dfe1.dir\Debug\" /Fd"cmTC_8dfe1.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_8dfe1.dir\Debug\" /Fd"cmTC_8dfe1.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_8dfe1.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_8dfe1.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_8dfe1.lib" /MACHINE:X64 /machine:x64 cmTC_8dfe1.dir\Debug\src.obj
cmTC_8dfe1.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_8dfe1.exe
FinalizeBuildStatus:
Deleting file "cmTC_8dfe1.dir\Debug\cmTC_8dfe1.tlog\unsuccessfulbuild".
Touching "cmTC_8dfe1.dir\Debug\cmTC_8dfe1.tlog\cmTC_8dfe1.lastbuildstate".
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_8dfe1.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.26
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_78186.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_78186.dir\Debug\cmTC_78186.tlog\".
InitializeBuildStatus:
Creating "cmTC_78186.dir\Debug\cmTC_78186.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_78186.dir\Debug\" /Fd"cmTC_78186.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_78186.dir\Debug\" /Fd"cmTC_78186.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_78186.vcxproj]
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_78186.vcxproj" (default targets) -- FAILED.
Build FAILED.
"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_78186.vcxproj" (default target) (1) ->
(ClCompile target) ->
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_78186.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:00.63
```
- Mesos Reviewbot Windows
On Jan. 23, 2018, 10:17 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2018, 10:17 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
>
>
> Diffs
> -----
>
> src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
>
>
> Diff: https://reviews.apache.org/r/64618/diff/2/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196301
-----------------------------------------------------------
src/master/master.cpp
Lines 5841-5850 (patched)
<https://reviews.apache.org/r/64618/#comment275850>
As discussed offline, let's leave the validation in the top-level scheduler API handler, and increment invalid metrics there.
src/master/master.cpp
Lines 5877-5895 (patched)
<https://reviews.apache.org/r/64618/#comment275851>
Per our offline discussion, consider not incrementing invalid metrics in these cases.
- Greg Mann
On Jan. 23, 2018, 10:17 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2018, 10:17 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
>
>
> Diffs
> -----
>
> src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
>
>
> Diff: https://reviews.apache.org/r/64618/diff/2/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196528
-----------------------------------------------------------
src/master/master.cpp
Lines 5892-5893 (patched)
<https://reviews.apache.org/r/64618/#comment276212>
Since the UUID is associated with the status, what do you think about the following wording:
"Processing ACKNOWLEDGE_OPERATION_STATUS call for status <uuid> of operation '<operation_id>' etc...."
src/master/master.cpp
Lines 5898-5906 (patched)
<https://reviews.apache.org/r/64618/#comment276214>
Hmm... will the operation's list of statuses ever be empty when a valid ACK is received?
Also, do we need to update the latest status here? We already do it upon receipt of the status update, via `updateOperation()`.
I think the correct logic here might be something like:
```
if (protobuf::isTerminalState(
(*operation->statuses().rbegin()).state())) {
removeOperation(operation);
}
```
src/master/master.cpp
Lines 5903 (patched)
<https://reviews.apache.org/r/64618/#comment276215>
Rather than just conditionally updating master state if the status UUID is correct, should we validate that the UUID in the call is correct, and drop the message if not? Seems strange to send an ACK containing an invalid status UUID to the agent.
- Greg Mann
On Jan. 26, 2018, 10:09 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 10:09 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
>
>
> Diffs
> -----
>
> src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990
> src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
>
>
> Diff: https://reviews.apache.org/r/64618/diff/3/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196535
-----------------------------------------------------------
PASS: Mesos patch 64618 was successfully built and tested.
Reviews applied: `['65357', '65358', '65359', '65360', '65361', '65300', '65362', '65363', '64618']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618
- Mesos Reviewbot Windows
On Jan. 30, 2018, 9:22 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2018, 9:22 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
>
>
> Diffs
> -----
>
> src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990
> src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
>
>
> Diff: https://reviews.apache.org/r/64618/diff/4/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
> On March 13, 2018, 4:19 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 5960 (patched)
> > <https://reviews.apache.org/r/64618/diff/6/?file=1974232#file1974232line5961>
> >
> > Can we move this to?
> >
> > `std::move(statusUuid.toBytes())`
> >
> > Looks like `toBytes()` returns a `std::string` and `set_value` has an overload for rvalue reference, so I think we can avoid a copy here if we move?
>
> Gaston Kleiman wrote:
> Since `statusUuid.toBytes()` here is an rvalue, I think that `set_value(std::string&&)` should be automatically used. I updated the patch anyway for the sake of explicitness/readability.
Well.. I just noticed that adding `std::move` breaks the build, so I reverted that part. Here's the error that it triggers:
```
master/master.cpp:6006:44: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
message.mutable_status_uuid()->set_value(std::move(statusUuid.toBytes()));
^
../../src/master/master.cpp:6006:44: note: remove std::move call here
message.mutable_status_uuid()->set_value(std::move(statusUuid.toBytes()));
^~~~~~~~~~ ~
```
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199128
-----------------------------------------------------------
On March 14, 2018, 4:50 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated March 14, 2018, 4:50 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
>
>
> Diffs
> -----
>
> src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f
> src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947
> src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
>
>
> Diff: https://reviews.apache.org/r/64618/diff/8/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
> On March 13, 2018, 4:19 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 5960 (patched)
> > <https://reviews.apache.org/r/64618/diff/6/?file=1974232#file1974232line5961>
> >
> > Can we move this to?
> >
> > `std::move(statusUuid.toBytes())`
> >
> > Looks like `toBytes()` returns a `std::string` and `set_value` has an overload for rvalue reference, so I think we can avoid a copy here if we move?
Since `statusUuid.toBytes()` here is an rvalue, I think that `set_value(std::string&&)` should be automatically used. I updated the patch anyway for the sake of explicitness/readability.
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199128
-----------------------------------------------------------
On March 14, 2018, 2:01 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated March 14, 2018, 2:01 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
>
>
> Diffs
> -----
>
> src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f
> src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947
> src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
>
>
> Diff: https://reviews.apache.org/r/64618/diff/7/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199128
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 5960 (patched)
<https://reviews.apache.org/r/64618/#comment279433>
Can we move this to?
`std::move(statusUuid.toBytes())`
Looks like `toBytes()` returns a `std::string` and `set_value` has an overload for rvalue reference, so I think we can avoid a copy here if we move?
- Greg Mann
On Feb. 1, 2018, 11:52 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 11:52 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
>
>
> Diffs
> -----
>
> src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f
> src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947
> src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
>
>
> Diff: https://reviews.apache.org/r/64618/diff/6/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
-----------------------------------------------------------
(Updated March 14, 2018, 4:50 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Reverted last revision to fix the build.
Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description
-------
Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
Diffs (updated)
-----
src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f
src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947
src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
Diff: https://reviews.apache.org/r/64618/diff/8/
Changes: https://reviews.apache.org/r/64618/diff/7-8/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
-----------------------------------------------------------
(Updated March 14, 2018, 2:01 a.m.)
Review request for mesos and Greg Mann.
Changes
-------
Addressed Greg's comment.
Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description
-------
Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
Diffs (updated)
-----
src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f
src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947
src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
Diff: https://reviews.apache.org/r/64618/diff/7/
Changes: https://reviews.apache.org/r/64618/diff/6-7/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
-----------------------------------------------------------
(Updated Feb. 1, 2018, 3:52 p.m.)
Review request for mesos and Greg Mann.
Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description
-------
Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
Diffs (updated)
-----
src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990
src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381
Diff: https://reviews.apache.org/r/64618/diff/5/
Changes: https://reviews.apache.org/r/64618/diff/4-5/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
-----------------------------------------------------------
(Updated Jan. 30, 2018, 1:22 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Addressed feedback.
Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description
-------
Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
Diffs (updated)
-----
src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990
src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
Diff: https://reviews.apache.org/r/64618/diff/4/
Changes: https://reviews.apache.org/r/64618/diff/3-4/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196375
-----------------------------------------------------------
PASS: Mesos patch 64618 was successfully built and tested.
Reviews applied: `['65357', '65358', '65359', '65360', '65361', '65300', '65362', '65363', '64618']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618
- Mesos Reviewbot Windows
On Jan. 26, 2018, 10:09 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 10:09 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
>
>
> Diffs
> -----
>
> src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990
> src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
>
>
> Diff: https://reviews.apache.org/r/64618/diff/3/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196377
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65357', '65358', '65359', '65360', '65361', '65300', '65362', '65363', '64618']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (3439 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (3465 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (3568 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (3594 ms total)
[----------] Global test environment tear-down
D:\DCOS\mesos\mesos\src\tests\environment.cpp(832): error: Failed
Tests completed with child processes remaining:
-+- 828 0000008E7AB9E47C
|-+- 10360 0000008E7AB9E47C
| --- 5824 0000008E7AB9E47C
|-+- 11000 0000008E7AB9E47C
| --- 9868 0000008E7AB9E47C
-+- 11328 0000008E7AB9E47C
--- 13696 0000008E7AB9E47C
[==========] 849 tests from 85 test cases ran. (361732 ms total)
[ PASSED ] 849 tests.
[ FAILED ] 0 tests, listed below:
0 FAILED TESTS
YOU HAVE 213 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-stderr.log):
```
I0126 23:48:48.659042 4904 master.cpp:10292] Updating the state of task 58247121-ef5f-4488-b94a-e20ee1ab773b of framework 08d9d427-72f2-4b58-8d63-ee25da06a3dc-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0126 23:48:48.659042 10084 slI0126 23:48:47.767930 10840 exec.cpp:162] Version: 1.6.0
I0126 23:48:47.793915 6644 exec.cpp:236] Executor registered on agent 08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0
I0126 23:48:47.796936 7844 executor.cpp:171] Received SUBSCRIBED event
I0126 23:48:47.801934 7844 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0126 23:48:47.801934 7844 executor.cpp:171] Received LAUNCH event
I0126 23:48:47.806936 7844 executor.cpp:638] Starting task 58247121-ef5f-4488-b94a-e20ee1ab773b
I0126 23:48:47.882922 7844 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0126 23:48:48.633067 7844 executor.cpp:651] Forked command at 9200
I0126 23:48:48.661043 13576 exec.cpp:445] Executor asked to shutdown
I0126 23:48:48.661043 7844 executor.cpp:171] Received SHUTDOWN event
I0126 23:48:48.661043 7844 executor.cpp:748] Shutting down
I0126 23:48:48.662041 7844 executor.cpp:863] Sending SIGTERM to process tree at pid 9ave.cpp:3479] Shutting down framework 08d9d427-72f2-4b58-8d63-ee25da06a3dc-0000
I0126 23:48:48.659042 10084 slave.cpp:6178] Shutting down executor '58247121-ef5f-4488-b94a-e20ee1ab773b' of framework 08d9d427-72f2-4b58-8d63-ee25da06a3dc-0000 at executor(1)@10.3.1.11:65166
I0126 23:48:48.660043 10084 slave.cpp:931] Agent terminating
W0126 23:48:48.660043 10084 slave.cpp:3475] Ignoring shutdown framework 08d9d427-72f2-4b58-8d63-ee25da06a3dc-0000 because it is terminating
I0126 23:48:48.662041 4904 master.cpp:10391] Removing task 58247121-ef5f-4488-b94a-e20ee1ab773b with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 08d9d427-72f2-4b58-8d63-ee25da06a3dc-0000 on agent 08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0 at slave(329)@10.3.1.11:65144 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0126 23:48:48.664042 10084 containerizer.cpp:2338] Destroying container ad7fdb26-819f-43f5-9b00-ee9c5daf6159 in RUNNING state
I0126 23:48:48.664042 10084 containerizer.cpp:2952] Transitioning the state of container ad7fdb26-819f-43f5-9b00-ee9c5daf6159 from RUNNING to DESTROYING
I0126 23:48:48.664042 4904 master.cpp:1307] Agent 08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0 at slave(329)@10.3.1.11:65144 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0126 23:48:48.664042 4904 master.cpp:3277] Disconnecting agent 08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0 at slave(329)@10.3.1.11:65144 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0126 23:48:48.664042 4904 master.cpp:3296] Deactivating agent 08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0 at slave(329)@10.3.1.11:65144 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0126 23:48:48.665071 10280 hierarchical.cpp:344] Removed framework 08d9d427-72f2-4b58-8d63-ee25da06a3dc-0000
I0126 23:48:48.665071 10084 launcher.cpp:156] Asked to destroy container ad7fdb26-819f-43f5-9b00-ee9c5daf6159
I0126 23:48:48.665071 10280 hierarchical.cpp:766] Agent 08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0 deactivated
I0126 23:48:48.769151 10556 containerizer.cpp:2791] Container ad7fdb26-819f-43f5-9b00-ee9c5daf6159 has exited
I0126 23:48:48.799129 13236 master.cpp:1149] Master terminating
I0126 23:48:48.801126 10280 hierarchical.cpp:609] Removed agent 08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0
I0126 23:48:49.185096 1248 process.cpp:928] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 26, 2018, 2:09 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2018, 2:09 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
>
>
> Diffs
> -----
>
> src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990
> src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
>
>
> Diff: https://reviews.apache.org/r/64618/diff/3/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
-----------------------------------------------------------
(Updated Jan. 26, 2018, 2:09 p.m.)
Review request for mesos and Greg Mann.
Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description
-------
Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
Diffs (updated)
-----
src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990
src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
Diff: https://reviews.apache.org/r/64618/diff/3/
Changes: https://reviews.apache.org/r/64618/diff/2-3/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 64618: Implemented the master's
`ACKNOWLEDGE_OPERATION_STATUS` handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
-----------------------------------------------------------
(Updated Jan. 23, 2018, 2:17 p.m.)
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
Changes
-------
Rebased.
Summary (updated)
-----------------
Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description (updated)
-------
Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
Diffs (updated)
-----
src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
Diff: https://reviews.apache.org/r/64618/diff/2/
Changes: https://reviews.apache.org/r/64618/diff/1-2/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman