You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampipes.apache.org by ri...@apache.org on 2022/08/22 11:00:35 UTC
[incubator-streampipes] branch rel/0.70.0 updated: [hotfix] Avoid refresh on field selection in schema editor
This is an automated email from the ASF dual-hosted git repository.
riemer pushed a commit to branch rel/0.70.0
in repository https://gitbox.apache.org/repos/asf/incubator-streampipes.git
The following commit(s) were added to refs/heads/rel/0.70.0 by this push:
new 392ff556a [hotfix] Avoid refresh on field selection in schema editor
392ff556a is described below
commit 392ff556a88b2236bc381555d54a08718b61bddb
Author: Dominik Riemer <do...@gmail.com>
AuthorDate: Mon Aug 22 12:59:53 2022 +0200
[hotfix] Avoid refresh on field selection in schema editor
---
.../event-property-row/event-property-row.component.ts | 8 ++++----
.../schema-editor/event-schema/event-schema.component.html | 2 +-
.../schema-editor/event-schema/event-schema.component.ts | 6 ++++--
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/ui/src/app/connect/components/new-adapter/schema-editor/event-property-row/event-property-row.component.ts b/ui/src/app/connect/components/new-adapter/schema-editor/event-property-row/event-property-row.component.ts
index 393066c93..cd561af21 100644
--- a/ui/src/app/connect/components/new-adapter/schema-editor/event-property-row/event-property-row.component.ts
+++ b/ui/src/app/connect/components/new-adapter/schema-editor/event-property-row/event-property-row.component.ts
@@ -52,7 +52,7 @@ export class EventPropertyRowComponent implements OnInit {
@Output() isEditableChange = new EventEmitter<boolean>();
@Output() eventSchemaChange = new EventEmitter<EventSchema>();
@Output() originalEventSchemaChange = new EventEmitter<EventSchema>();
- @Output() refreshTreeEmitter = new EventEmitter<void>();
+ @Output() refreshTreeEmitter = new EventEmitter<boolean>();
@Output() countSelectedChange = new EventEmitter<number>();
label: string;
@@ -152,7 +152,7 @@ export class EventPropertyRowComponent implements OnInit {
dialogRef.afterClosed().subscribe(refresh => {
this.timestampProperty = this.isTimestampProperty(this.node.data);
- this.refreshTreeEmitter.emit();
+ this.refreshTreeEmitter.emit(true);
});
}
@@ -204,7 +204,7 @@ export class EventPropertyRowComponent implements OnInit {
}
}
this.countSelectedChange.emit(this.countSelected);
- this.refreshTreeEmitter.emit();
+ this.refreshTreeEmitter.emit(false);
}
public addNestedProperty(eventProperty: EventPropertyNested): void {
@@ -215,6 +215,6 @@ export class EventPropertyRowComponent implements OnInit {
const property: EventPropertyNested = new EventPropertyNested();
property.elementId = uuid;
eventProperty.eventProperties.push(property);
- this.refreshTreeEmitter.emit();
+ this.refreshTreeEmitter.emit(false);
}
}
diff --git a/ui/src/app/connect/components/new-adapter/schema-editor/event-schema/event-schema.component.html b/ui/src/app/connect/components/new-adapter/schema-editor/event-schema/event-schema.component.html
index a478d6fbb..5990ea8ba 100644
--- a/ui/src/app/connect/components/new-adapter/schema-editor/event-schema/event-schema.component.html
+++ b/ui/src/app/connect/components/new-adapter/schema-editor/event-schema/event-schema.component.html
@@ -97,7 +97,7 @@
[(originalEventSchema)]="oldEventSchema"
[eventPreview]="eventPreview"
[fieldStatusInfo]="fieldStatusInfo"
- (refreshTreeEmitter)="refreshTree()"
+ (refreshTreeEmitter)="refreshTree($event)"
[(countSelected)]="countSelected"></event-property-row>
</ng-template>
</tree-root>
diff --git a/ui/src/app/connect/components/new-adapter/schema-editor/event-schema/event-schema.component.ts b/ui/src/app/connect/components/new-adapter/schema-editor/event-schema/event-schema.component.ts
index b18a8e13c..30c340a68 100644
--- a/ui/src/app/connect/components/new-adapter/schema-editor/event-schema/event-schema.component.ts
+++ b/ui/src/app/connect/components/new-adapter/schema-editor/event-schema/event-schema.component.ts
@@ -142,11 +142,13 @@ export class EventSchemaComponent implements OnChanges {
}
- private refreshTree(): void {
+ private refreshTree(refreshPreview = true): void {
this.nodes = new Array<EventProperty>();
this.nodes.push(this.eventSchema as unknown as EventProperty);
this.validEventSchema = this.checkIfValid(this.eventSchema);
- this.updatePreview();
+ if (refreshPreview) {
+ this.updatePreview();
+ }
}
public addNestedProperty(eventProperty?: EventPropertyNested): void {