You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/11/27 13:46:42 UTC
[GitHub] [groovy] hdfg159 opened a new pull request #1435: JmxBuilder export bean:specifying MBean ObjectName support GString.
hdfg159 opened a new pull request #1435:
URL: https://github.com/apache/groovy/pull/1435
https://issues.apache.org/jira/browse/GROOVY-9829
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1435: JmxBuilder export bean:specifying MBean ObjectName support GString.
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1435:
URL: https://github.com/apache/groovy/pull/1435#issuecomment-735033981
Merged, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] hdfg159 commented on a change in pull request #1435: JmxBuilder export bean:specifying MBean ObjectName support GString.
Posted by GitBox <gi...@apache.org>.
hdfg159 commented on a change in pull request #1435:
URL: https://github.com/apache/groovy/pull/1435#discussion_r531812091
##########
File path: subprojects/groovy-jmx/src/main/groovy/groovy/jmx/builder/JmxMetaMapBuilder.groovy
##########
@@ -172,7 +172,7 @@ class JmxMetaMapBuilder {
private static ObjectName getObjectName(def map) {
if (!map) return null
def jmxName
- if (map.name instanceof String) {
+ if (map.name instanceof String || map.name instanceof GString) {
Review comment:
Thanks for the suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] eric-milles commented on a change in pull request #1435: JmxBuilder export bean:specifying MBean ObjectName support GString.
Posted by GitBox <gi...@apache.org>.
eric-milles commented on a change in pull request #1435:
URL: https://github.com/apache/groovy/pull/1435#discussion_r531720936
##########
File path: subprojects/groovy-jmx/src/main/groovy/groovy/jmx/builder/JmxMetaMapBuilder.groovy
##########
@@ -172,7 +172,7 @@ class JmxMetaMapBuilder {
private static ObjectName getObjectName(def map) {
if (!map) return null
def jmxName
- if (map.name instanceof String) {
+ if (map.name instanceof String || map.name instanceof GString) {
Review comment:
Would "instanceof CharSequence" cover it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a change in pull request #1435: JmxBuilder export bean:specifying MBean ObjectName support GString.
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on a change in pull request #1435:
URL: https://github.com/apache/groovy/pull/1435#discussion_r531792944
##########
File path: subprojects/groovy-jmx/src/main/groovy/groovy/jmx/builder/JmxMetaMapBuilder.groovy
##########
@@ -172,7 +172,7 @@ class JmxMetaMapBuilder {
private static ObjectName getObjectName(def map) {
if (!map) return null
def jmxName
- if (map.name instanceof String) {
+ if (map.name instanceof String || map.name instanceof GString) {
Review comment:
I'll merge but tweak with the suggestion from @eric-milles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] asfgit closed pull request #1435: JmxBuilder export bean:specifying MBean ObjectName support GString.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1435:
URL: https://github.com/apache/groovy/pull/1435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org