You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/22 20:28:04 UTC
[GitHub] [kafka] C0urante opened a new pull request, #12433: KAFKA-14093: Use single-worker Connect cluster when testing fenced leader recovery
C0urante opened a new pull request, #12433:
URL: https://github.com/apache/kafka/pull/12433
Largely copied from [Jira](https://issues.apache.org/jira/browse/KAFKA-14093):
The Javadoc for the `testFencedLeaderRecovery` test case calls out that it uses a one-node cluster, and the [check we do](https://github.com/apache/kafka/blob/679e9e0cee67e7d3d2ece204a421ea7da31d73e9/connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java#L493-L494) to make sure that the leader is up and running (and has had a chance to instantiate its transactional producer for the config topic) relies on that fact. However, we don't reduce the cluster size to one in the test, so right now it's running with the default of three workers.
As a result, it's possible that the readiness check we're doing hits a follower worker and passes before the leader has had a chance to finish startup.
These changes fix that issue by ensuring that the test runs with only a single worker. In addition, the transactional producers brought up for testing are given meaningful client IDs so that they can be easily distinguished from the producers brought up by the embedded Connect cluster.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #12433: KAFKA-14093: Use single-worker Connect cluster when testing fenced leader recovery
Posted by GitBox <gi...@apache.org>.
C0urante commented on PR #12433:
URL: https://github.com/apache/kafka/pull/12433#issuecomment-1194542890
Thanks guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #12433: KAFKA-14093: Use single-worker Connect cluster when testing fenced leader recovery
Posted by GitBox <gi...@apache.org>.
mimaison commented on PR #12433:
URL: https://github.com/apache/kafka/pull/12433#issuecomment-1194059039
@jsancio I'm backporting this to 3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #12433: KAFKA-14093: Use single-worker Connect cluster when testing fenced leader recovery
Posted by GitBox <gi...@apache.org>.
mimaison merged PR #12433:
URL: https://github.com/apache/kafka/pull/12433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org