You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/12/05 02:01:45 UTC
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2839:
[GOBBLIN-993] Support job level hive configuration override
codecov-io edited a comment on issue #2839: [GOBBLIN-993] Support job level hive configuration override
URL: https://github.com/apache/incubator-gobblin/pull/2839#issuecomment-561929714
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2839?src=pr&el=h1) Report
> Merging [#2839](https://codecov.io/gh/apache/incubator-gobblin/pull/2839?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/6e55a16c68c29cb9331dda77f77d6b256a7bdfda?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2839?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2839 +/- ##
============================================
+ Coverage 45.61% 45.65% +0.04%
- Complexity 8972 8985 +13
============================================
Files 1903 1903
Lines 71315 71327 +12
Branches 7868 7871 +3
============================================
+ Hits 32531 32567 +36
+ Misses 35785 35762 -23
+ Partials 2999 2998 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2839?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/gobblin/hive/HiveMetastoreClientPool.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2839/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVNZXRhc3RvcmVDbGllbnRQb29sLmphdmE=) | `48.61% <83.33%> (+48.61%)` | `9 <3> (+9)` | :arrow_up: |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2839/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `32.71% <0%> (-6.55%)` | `11% <0%> (-2%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2839/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `64.35% <0%> (-0.47%)` | `27% <0%> (-1%)` | |
| [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2839/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh) | `79.68% <0%> (+1.56%)` | `16% <0%> (+1%)` | :arrow_up: |
| [...ain/java/org/apache/gobblin/hive/HiveRegProps.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2839/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVSZWdQcm9wcy5qYXZh) | `41.17% <0%> (+2.94%)` | `8% <0%> (+1%)` | :arrow_up: |
| [...pache/gobblin/hive/HiveMetaStoreClientFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2839/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVNZXRhU3RvcmVDbGllbnRGYWN0b3J5LmphdmE=) | `41.37% <0%> (+13.79%)` | `7% <0%> (+3%)` | :arrow_up: |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2839/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `100% <0%> (+14.28%)` | `4% <0%> (+1%)` | :arrow_up: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2839/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2839?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2839?src=pr&el=footer). Last update [6e55a16...b10d001](https://codecov.io/gh/apache/incubator-gobblin/pull/2839?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services