[GitHub] [iceberg] rdblue commented on a diff in pull request #7536: Core: Add finalizer to ResolvingFileIO

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #7536:
URL: https://github.com/apache/iceberg/pull/7536#discussion_r1186253995


##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -83,21 +90,22 @@ public Map<String, String> properties() {
 
   @Override
   public void initialize(Map<String, String> newProperties) {
-    close(); // close and discard any existing FileIO instances

Review Comment:
   It was just in case `initialize` was called again. Technically, that invalidates the configuration and we should close/reopen any FileIO instances that are held.
   
   We could just reset `isClosed` in this method instead of removing this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org