You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2020/06/23 13:16:53 UTC
[Impala-ASF-CR] IMPALA-9871: Simplify OS version matching for SLES in bootstrap toolchain.py
Hello Attila Jeges, Joe McDonnell,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/16102
to review the following change.
Change subject: IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py
......................................................................
IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py
bin/bootstrap_toolchain.py failed to recognize SLES12 sp5, which broke
builds on that platform.
This patch simplifies OS version parsing and matching for SLES, omitting
the check for the OS minor version, which shows the SP level for SLES.
This is similar to how Red Hat variants are handled. This gets
rid of the constant update need whenever a new SP level is released for
SLES12.
This is enabled by the native toolchain sharing a single set of artifacts
between all the SLES12 SP levels.
Test: ran a successful build on a SLES12sp5 box.
Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
---
M bin/bootstrap_toolchain.py
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/16102/1
--
To view, visit http://gerrit.cloudera.org:8080/16102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
Gerrit-Change-Number: 16102
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9871: Simplify OS version matching for SLES in bootstrap toolchain.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16102 )
Change subject: IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
Gerrit-Change-Number: 16102
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 23:53:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9871: Simplify OS version matching for SLES in bootstrap toolchain.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16102 )
Change subject: IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py
......................................................................
IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py
bin/bootstrap_toolchain.py failed to recognize SLES12 sp5, which broke
builds on that platform.
This patch simplifies OS version parsing and matching for SLES, omitting
the check for the OS minor version, which shows the SP level for SLES.
This is similar to how Red Hat variants are handled. This gets
rid of the constant update need whenever a new SP level is released for
SLES12.
This is enabled by the native toolchain sharing a single set of artifacts
between all the SLES12 SP levels.
Test: ran a successful build on a SLES12sp5 box.
Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
Reviewed-on: http://gerrit.cloudera.org:8080/16102
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_toolchain.py
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
Gerrit-Change-Number: 16102
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9871: Simplify OS version matching for SLES in bootstrap toolchain.py
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16102 )
Change subject: IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/16102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
Gerrit-Change-Number: 16102
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 15:39:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9871: Simplify OS version matching for SLES in bootstrap toolchain.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16102 )
Change subject: IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
Gerrit-Change-Number: 16102
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 18:49:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9871: Simplify OS version matching for SLES in bootstrap toolchain.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16102 )
Change subject: IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6396/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
Gerrit-Change-Number: 16102
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 13:44:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9871: Simplify OS version matching for SLES in bootstrap toolchain.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16102 )
Change subject: IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6037/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9ada210b915050fbceebb7364e130116e9244d0
Gerrit-Change-Number: 16102
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 18:49:42 +0000
Gerrit-HasComments: No