You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/04/13 17:58:10 UTC
[GitHub] [lucene] dweiss commented on a diff in pull request #811: Add some basic tasks to help/workflow
dweiss commented on code in PR #811:
URL: https://github.com/apache/lucene/pull/811#discussion_r849753568
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
+gradlew assemble
+
Create all distributable packages, POMs, etc. and create a
local maven repository for inspection:
gradlew mavenLocal
ls -R build/maven-local/
+Assemble Javdocs on a module:
Review Comment:
This is a general question on where to explain how gradle works (-p command) and whether this document should provide ready-to-use commands doing things or an explanation how to assemble those commands from scratch. I'm not sure how much people are willing to read about gradle... :)
Separately - do you ever assemble javadocs for a single module? What's the point of doing that?
##########
help/workflow.txt:
##########
@@ -25,11 +25,22 @@ Assemble a single module's JAR (here for lucene-core):
gradlew -p lucene/core assemble
ls lucene/core/build/libs
+Assemble all JARs:
Review Comment:
This convention task is for assembling... well, things that need to be assembled. It's not just JARs but typically also other stuff (say, the documentation could be assembled from sources). I'm not sure if it makes a difference but perhaps it's worth clarifying here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org