You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/04/13 13:49:32 UTC
[GitHub] [camel-quarkus-examples] JiriOndrusek opened a new pull request, #139: ObservabilityTest.metrics in examples fails #4773
JiriOndrusek opened a new pull request, #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139
fixes https://github.com/apache/camel-quarkus/issues/4773
Reflects change in micrometer metrics from Camel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] JiriOndrusek commented on a diff in pull request #139: ObservabilityTest.metrics in examples fails #4773
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139#discussion_r1168411309
##########
observability/src/test/java/org/acme/observability/ObservabilityTest.java:
##########
@@ -52,7 +52,7 @@ public void metrics() {
long camelMetricCount = path.getMap("$.")
.keySet()
.stream()
- .filter(key -> key.toString().startsWith("Camel"))
+ .filter(key -> key.toString().startsWith("camel"))
Review Comment:
makes sense, thanks for the tip (I thought that c-q-examples should be updated only with `camel-main` branch in mind, and will be merged to `main` with the new c-q....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] JiriOndrusek commented on a diff in pull request #139: ObservabilityTest.metrics in examples fails #4773
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139#discussion_r1168413532
##########
observability/src/test/java/org/acme/observability/ObservabilityTest.java:
##########
@@ -52,7 +52,7 @@ public void metrics() {
long camelMetricCount = path.getMap("$.")
.keySet()
.stream()
- .filter(key -> key.toString().startsWith("Camel"))
+ .filter(key -> key.toString().startsWith("camel"))
Review Comment:
Still a valid point and I'll changeit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] JiriOndrusek commented on a diff in pull request #139: ObservabilityTest.metrics in examples fails #4773
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139#discussion_r1168881513
##########
observability/src/test/java/org/acme/observability/ObservabilityTest.java:
##########
@@ -52,7 +52,7 @@ public void metrics() {
long camelMetricCount = path.getMap("$.")
.keySet()
.stream()
- .filter(key -> key.toString().startsWith("Camel"))
+ .filter(key -> key.toString().startsWith("camel"))
Review Comment:
ok, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] JiriOndrusek commented on a diff in pull request #139: ObservabilityTest.metrics in examples fails #4773
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139#discussion_r1168561784
##########
observability/src/test/java/org/acme/observability/ObservabilityTest.java:
##########
@@ -52,7 +52,7 @@ public void metrics() {
long camelMetricCount = path.getMap("$.")
.keySet()
.stream()
- .filter(key -> key.toString().startsWith("Camel"))
+ .filter(key -> key.toString().startsWith("camel"))
Review Comment:
@jamesnetherton Do we still want to marge it to camel-quarkus-main`, or should I rebase iPR to `main` -> as the change works for both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] JiriOndrusek commented on a diff in pull request #139: ObservabilityTest.metrics in examples fails #4773
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139#discussion_r1168561784
##########
observability/src/test/java/org/acme/observability/ObservabilityTest.java:
##########
@@ -52,7 +52,7 @@ public void metrics() {
long camelMetricCount = path.getMap("$.")
.keySet()
.stream()
- .filter(key -> key.toString().startsWith("Camel"))
+ .filter(key -> key.toString().startsWith("camel"))
Review Comment:
@jamesnetherton Do we still want to merge fix to camel-quarkus-main`, or should I rebase iPR to `main` -> as the change works for both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] jamesnetherton merged pull request #139: ObservabilityTest.metrics in examples fails #4773
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] jamesnetherton commented on a diff in pull request #139: ObservabilityTest.metrics in examples fails #4773
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139#discussion_r1168570411
##########
observability/src/test/java/org/acme/observability/ObservabilityTest.java:
##########
@@ -52,7 +52,7 @@ public void metrics() {
long camelMetricCount = path.getMap("$.")
.keySet()
.stream()
- .filter(key -> key.toString().startsWith("Camel"))
+ .filter(key -> key.toString().startsWith("camel"))
Review Comment:
`camel-quarkus-main` should be enough because both the CQ `main` & `camel-main` branch CI builds will check it out.
https://github.com/apache/camel-quarkus/blob/main/.github/workflows/ci-build.yaml#L466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] jamesnetherton commented on a diff in pull request #139: ObservabilityTest.metrics in examples fails #4773
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139#discussion_r1168237749
##########
observability/src/test/java/org/acme/observability/ObservabilityTest.java:
##########
@@ -52,7 +52,7 @@ public void metrics() {
long camelMetricCount = path.getMap("$.")
.keySet()
.stream()
- .filter(key -> key.toString().startsWith("Camel"))
+ .filter(key -> key.toString().startsWith("camel"))
Review Comment:
```suggestion
.filter(key -> key.toString().toLowerCase().startsWith("camel"))
```
This way it'll work for both the CQ `main` branch and `camel-main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] JiriOndrusek commented on a diff in pull request #139: ObservabilityTest.metrics in examples fails #4773
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139#discussion_r1168411309
##########
observability/src/test/java/org/acme/observability/ObservabilityTest.java:
##########
@@ -52,7 +52,7 @@ public void metrics() {
long camelMetricCount = path.getMap("$.")
.keySet()
.stream()
- .filter(key -> key.toString().startsWith("Camel"))
+ .filter(key -> key.toString().startsWith("camel"))
Review Comment:
makes sense, thanks for the tip (I thought that c-q-examples should be updated only with `camel-main` branch in mind, and will be merged to `main` with the new c-q.... That making it work with main is not needed as the main will be camel-main in time this PR is released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus-examples] JiriOndrusek commented on a diff in pull request #139: ObservabilityTest.metrics in examples fails #4773
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #139:
URL: https://github.com/apache/camel-quarkus-examples/pull/139#discussion_r1168561784
##########
observability/src/test/java/org/acme/observability/ObservabilityTest.java:
##########
@@ -52,7 +52,7 @@ public void metrics() {
long camelMetricCount = path.getMap("$.")
.keySet()
.stream()
- .filter(key -> key.toString().startsWith("Camel"))
+ .filter(key -> key.toString().startsWith("camel"))
Review Comment:
@jamesnetherton Do we still want to merge fix to `camel-quarkus-main`, or should I rebase PR to `main` -> as the change works for both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org