You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@baremaps.apache.org by "YongGoose (via GitHub)" <gi...@apache.org> on 2025/01/25 11:33:59 UTC
[PR] Update Maplibre to version 5 [incubator-baremaps]
YongGoose opened a new pull request, #924:
URL: https://github.com/apache/incubator-baremaps/pull/924
Resolves #922
This PR updates the Maplibre library to version 5.0.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2613936211
## [](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=924) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=924&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=924&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=924&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=924&metric=new_coverage&view=list)
 [66.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=924&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=924)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2621956789
> I'm not completely sure why you get this error. On my side, it works for 127.0.0.1:9000 and localhost:9000. I will try to test it with a different browser and maybe ask someone else to test it. Overall, things look good to me.
Thank you! 👍🏻
I'll try testing it with a different browser as well.
PS. The template is currently a work in progress, and I'll create a PR once it's completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2614444531
Thanks a lot for this contribution.
I have tried this change with the `dev` and `serve` command of the baremaps CLI and got some Content Security Policy issues in the browser. After digging a bit, I managed to display the map by updating the value of the integrity attribute for the js and css files of maplibre and by adding a meta element at the top of the head section to declare the CSP.
Here are my changes:
```html
<meta http-equiv="Content-Security-Policy" content="
script-src 'self' 'unsafe-eval' 'unsafe-inline' https://unpkg.com https://baremaps.apache.org;
worker-src 'self' blob:;
child-src 'self' blob:;
img-src 'self' data: blob: https://unpkg.com https://baremaps.apache.org;
style-src 'self' 'unsafe-inline' https://unpkg.com https://baremaps.apache.org;
">
<script src="https://unpkg.com/maplibre-gl@5.0.1/dist/maplibre-gl.js" integrity="sha256-VkgYz8vlPsIndJcxwEDZKAdx4r+Ag7HcLBPP4UbJrZE=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-gl-inspect.js" integrity="sha256-NYdRoIbqeAWkTHjpa/BukMLXcsiqFoDuJCYzzaRei30=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-gl-tile-boundaries.js" integrity="sha256-Jo8NvxMzooqayU8+eIsjO49b4EoakoE0o0tSSrBWPCU=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-custom-controls.js" integrity="sha256-80a3VIbp5OJ8HSIWJ7+6NjTvdBmVirLCR6otKucXnlw=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-gl-framerate.js" integrity="sha256-6IVzv2heNDAl7KkSqjRkmjr56asfkdCxO2q8ouTo8t8=" crossorigin="anonymous"></script>
<link rel="stylesheet" href="https://unpkg.com/maplibre-gl@5.0.1/dist/maplibre-gl.css" integrity="sha256-eSrJl9z2rm9kPrTi3uRjDIXnBWUmvY+4X/6Dxn1sQbQ=" crossorigin="anonymous">
<link rel="stylesheet" href="https://baremaps.apache.org/assets/maplibre/maplibre-gl-inspect.css" integrity="sha256-ePhsoaklgbCBxK7kfSUcP+V+bVqnfFwpILz7hkSR0Lo=" crossorigin="anonymous">
<link rel="stylesheet" href="https://baremaps.apache.org/assets/maplibre/maplibre-gl-tile-boundaries.css" integrity="sha256-FxIRliWXnU67sT1i97MgNQ0qL8LjsgYiBH9v/uNxzdM=" crossorigin="anonymous">
<link rel="stylesheet" href="https://baremaps.apache.org/assets/maplibre/maplibre-custom-controls.css" integrity="sha256-rFc19qrZTPgcrNeYjtsLCcDOqM5NrLiPy2U+0FxW9vA=" crossorigin="anonymous">
<link rel="icon" type="image/x-icon" href="https://baremaps.apache.org/assets/favicon/favicon.ico">
```
Can you cross check and validate that it works for you as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2626707624
> @YongGoose I further investigated the content security policy and I think that the error was comming from a chrome extention that interfered with the policy. It does not show up in incognito mode.
>
> I also tried to better understand why things were not working properly with localhost and 127.0.0.1 and I think it comes from the fact that they are not considered as the same by CSP. So here is a revised meta header works for all cases and is probably better. I also removed the eval-unsafe directive which was unecessary.
>
> ```
> <meta http-equiv="Content-Security-Policy" content="
> default-src 'self' http://127.0.0.1:* http://localhost:* https://unpkg.com https://baremaps.apache.org;
> script-src 'self' http://127.0.0.1:* http://localhost:* https://unpkg.com https://unpkg.com https://baremaps.apache.org 'unsafe-inline';
> worker-src 'self' blob:;
> child-src 'self' blob:;
> img-src 'self' data: blob: http://127.0.0.1:* http://localhost:* https://unpkg.com https://baremaps.apache.org;
> style-src 'self' 'unsafe-inline' http://127.0.0.1:* http://localhost:* https://unpkg.com https://baremaps.apache.org;
> ">
> ```
>
> Can you update the PR? I will then merge it and others will complain if it still has problems. To me things look good 👍
Thank you! 🙂
It looks good to me as well!
If any further issues arise, I’ll share them through the mailing list.
Done in https://github.com/apache/incubator-baremaps/commit/5b5e993e5af22bc7d679b9f35530c22da2816a4c !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2621681208
## [](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=924) **Quality Gate failed**
Failed conditions
 [100.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=924&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=924)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2626702621
## [](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=924) **Quality Gate failed**
Failed conditions
 [100.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=924&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=924)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2621938908
I'm not completely sure why you get this error. On my side, it works for 127.0.0.1:9000 and localhost:9000. I will try to test it with a different browser and maybe ask someone else to test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis merged PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2614479918
> Can you cross check and validate that it works for you as well?
I'll test the provided changes and validate the results.
Get back to you with my findings by tomorrow :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2626796248
Perfect, thanks a lot for your contribution 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2621702075
@bchapuis
Sorry for the delay.
I went on a vacation with my family 😅
---
First, I have reflected the changes in this commit. https://github.com/apache/incubator-baremaps/pull/924/commits/7be1623d837ef476e701efd7a3fb0e2d552a8804
> After digging a bit, I managed to display the map by updating the value of the integrity attribute for the js and css files of maplibre and by adding a meta element at the top of the head section to declare the CSP.
In my case, even after updating the integrity values as in the commit above and adding the meta element, the issue was not resolved.
To share more details about the problem, I will attach a screenshot along with the commands I executed.
### screenshot
### commands
```
baremaps map serve --tileset tileset.js --style style.js
```
> I ran the command in the Basemap directory
- **If I misunderstood or made any mistake, please feel free to let me know!**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on code in PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#discussion_r1933985447
##########
baremaps-server/src/main/resources/static/server.html:
##########
@@ -17,17 +17,24 @@
-->
<html lang="en">
<head>
- <script src="https://unpkg.com/maplibre-gl@4.5.0/dist/maplibre-gl.js" integrity="sha256-RU7N55x2fpxos26u6Mrn26qPlDih4ZiqZMstWPipnGE=" crossorigin="anonymous"></script>
+ <meta http-equiv="Content-Security-Policy" content="
+ script-src 'self' 'unsafe-eval' 'unsafe-inline' https://unpkg.com https://baremaps.apache.org;
+ worker-src 'self' blob:;
+ child-src 'self' blob:;
+ img-src 'self' data: blob: https://unpkg.com https://baremaps.apache.org;
+ style-src 'self' 'unsafe-inline' https://unpkg.com https://baremaps.apache.org;
+ ">
+
+ <script src="https://unpkg.com/maplibre-gl@5.0.1/dist/maplibre-gl.js" integrity="sha256-VkgYz8vlPsIndJcxwEDZKAdx4r+Ag7HcLBPP4UbJrZE=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-gl-inspect.js" integrity="sha256-NYdRoIbqeAWkTHjpa/BukMLXcsiqFoDuJCYzzaRei30=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-gl-tile-boundaries.js" integrity="sha256-Jo8NvxMzooqayU8+eIsjO49b4EoakoE0o0tSSrBWPCU=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-custom-controls.js" integrity="sha256-80a3VIbp5OJ8HSIWJ7+6NjTvdBmVirLCR6otKucXnlw=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-gl-framerate.js" integrity="sha256-6IVzv2heNDAl7KkSqjRkmjr56asfkdCxO2q8ouTo8t8=" crossorigin="anonymous"></script>
- <link rel="stylesheet" href="https://unpkg.com/maplibre-gl@4.5.0/dist/maplibre-gl.css" integrity="sha256-V2sIX92Uh6ZaGSFTKMHghsB85b9toJtmazgG09AI2uk=" crossorigin="anonymous">
+ <link rel="stylesheet" href="https://unpkg.com/maplibre-gl@5.0.1/dist/maplibre-gl.css" integrity="sha256-eSrJl9z2rm9kPrTi3uRjDIXnBWUmvY+4X/6Dxn1sQbQ=" crossorigin="anonymous">
<link rel="stylesheet" href="https://baremaps.apache.org/assets/maplibre/maplibre-gl-inspect.css" integrity="sha256-ePhsoaklgbCBxK7kfSUcP+V+bVqnfFwpILz7hkSR0Lo=" crossorigin="anonymous">
<link rel="stylesheet" href="https://baremaps.apache.org/assets/maplibre/maplibre-gl-tile-boundaries.css" integrity="sha256-FxIRliWXnU67sT1i97MgNQ0qL8LjsgYiBH9v/uNxzdM=" crossorigin="anonymous">
<link rel="stylesheet" href="https://baremaps.apache.org/assets/maplibre/maplibre-custom-controls.css" integrity="sha256-rFc19qrZTPgcrNeYjtsLCcDOqM5NrLiPy2U+0FxW9vA=" crossorigin="anonymous">
<link rel="icon" type="image/x-icon" href="https://baremaps.apache.org/assets/favicon/favicon.ico">
- <style>
Review Comment:
Done in https://github.com/apache/incubator-baremaps/commit/44aaacfde305e2109821ae28a532a0fe82f61d3f !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on code in PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#discussion_r1933954116
##########
baremaps-server/src/main/resources/static/server.html:
##########
@@ -17,17 +17,24 @@
-->
<html lang="en">
<head>
- <script src="https://unpkg.com/maplibre-gl@4.5.0/dist/maplibre-gl.js" integrity="sha256-RU7N55x2fpxos26u6Mrn26qPlDih4ZiqZMstWPipnGE=" crossorigin="anonymous"></script>
+ <meta http-equiv="Content-Security-Policy" content="
+ script-src 'self' 'unsafe-eval' 'unsafe-inline' https://unpkg.com https://baremaps.apache.org;
+ worker-src 'self' blob:;
+ child-src 'self' blob:;
+ img-src 'self' data: blob: https://unpkg.com https://baremaps.apache.org;
+ style-src 'self' 'unsafe-inline' https://unpkg.com https://baremaps.apache.org;
+ ">
+
+ <script src="https://unpkg.com/maplibre-gl@5.0.1/dist/maplibre-gl.js" integrity="sha256-VkgYz8vlPsIndJcxwEDZKAdx4r+Ag7HcLBPP4UbJrZE=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-gl-inspect.js" integrity="sha256-NYdRoIbqeAWkTHjpa/BukMLXcsiqFoDuJCYzzaRei30=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-gl-tile-boundaries.js" integrity="sha256-Jo8NvxMzooqayU8+eIsjO49b4EoakoE0o0tSSrBWPCU=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-custom-controls.js" integrity="sha256-80a3VIbp5OJ8HSIWJ7+6NjTvdBmVirLCR6otKucXnlw=" crossorigin="anonymous"></script>
<script src="https://baremaps.apache.org/assets/maplibre/maplibre-gl-framerate.js" integrity="sha256-6IVzv2heNDAl7KkSqjRkmjr56asfkdCxO2q8ouTo8t8=" crossorigin="anonymous"></script>
- <link rel="stylesheet" href="https://unpkg.com/maplibre-gl@4.5.0/dist/maplibre-gl.css" integrity="sha256-V2sIX92Uh6ZaGSFTKMHghsB85b9toJtmazgG09AI2uk=" crossorigin="anonymous">
+ <link rel="stylesheet" href="https://unpkg.com/maplibre-gl@5.0.1/dist/maplibre-gl.css" integrity="sha256-eSrJl9z2rm9kPrTi3uRjDIXnBWUmvY+4X/6Dxn1sQbQ=" crossorigin="anonymous">
<link rel="stylesheet" href="https://baremaps.apache.org/assets/maplibre/maplibre-gl-inspect.css" integrity="sha256-ePhsoaklgbCBxK7kfSUcP+V+bVqnfFwpILz7hkSR0Lo=" crossorigin="anonymous">
<link rel="stylesheet" href="https://baremaps.apache.org/assets/maplibre/maplibre-gl-tile-boundaries.css" integrity="sha256-FxIRliWXnU67sT1i97MgNQ0qL8LjsgYiBH9v/uNxzdM=" crossorigin="anonymous">
<link rel="stylesheet" href="https://baremaps.apache.org/assets/maplibre/maplibre-custom-controls.css" integrity="sha256-rFc19qrZTPgcrNeYjtsLCcDOqM5NrLiPy2U+0FxW9vA=" crossorigin="anonymous">
<link rel="icon" type="image/x-icon" href="https://baremaps.apache.org/assets/favicon/favicon.ico">
- <style>
Review Comment:
This style element is shouldn't be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2626681315
@YongGoose I further investigated the content security policy and I think that the error was comming from a chrome extention that interfered with the policy. It does not show up in incognito mode.
I also tried to better understand why things were not working properly with localhost and 127.0.0.1 and I think it comes from the fact that they are not considered as the same by CSP. So here is a revised meta header works for all cases and is probably better. I also removed the eval-unsafe directive which was unecessary.
```html
<meta http-equiv="Content-Security-Policy" content="
default-src 'self' http://127.0.0.1:* http://localhost:* https://unpkg.com https://baremaps.apache.org;
script-src 'self' http://127.0.0.1:* http://localhost:* https://unpkg.com https://unpkg.com https://baremaps.apache.org 'unsafe-inline';
worker-src 'self' blob:;
child-src 'self' blob:;
img-src 'self' data: blob: http://127.0.0.1:* http://localhost:* https://unpkg.com https://baremaps.apache.org;
style-src 'self' 'unsafe-inline' http://127.0.0.1:* http://localhost:* https://unpkg.com https://baremaps.apache.org;
">
```
Can you update the PR? I will then merge it and others will complain if it still has problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2626803507
> Perfect, thanks a lot for your contribution 🚀
You're welcome!
I'll do my best to achieve great results with baremaps going forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2621828042
> Thanks for the changes. The opening style element in server.html is missing. After this change both the dev and serve commands are working for me.
When opening a local file via a URL, the integrity error did not occur.
- I confirmed that the integrity error happens when the integrity value is changed in the case above.
> Could you try to perform a hard refresh or to open the url in anonymous mode? I'm not sure why you get a integrity error.
After clearing the cache and performing a hard refresh, the result was still the same.
However, I believe the issue lies with **my development environment**.
If it were a problem with the code, I think the same integrity error should occur when I open the local file through the URL.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Maplibre to version 5 [incubator-baremaps]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #924:
URL: https://github.com/apache/incubator-baremaps/pull/924#issuecomment-2621800384
## [](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=924) **Quality Gate failed**
Failed conditions
 [100.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=924&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=924)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org