[GitHub] ctubbsii commented on a change in pull request #451: #408 - Removing ClientConfiguration from Proxy code

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #451:  #408 - Removing ClientConfiguration from Proxy code
URL: https://github.com/apache/accumulo/pull/451#discussion_r185071199
 
 

 ##########
 File path: proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java
 ##########
 @@ -189,31 +188,23 @@ public void onRemoval(RemovalNotification<UUID,ConditionalWriter> notification)
 
   private final ThriftServerType serverType;
 
-  public ProxyServer(Properties props) {
+  public ProxyServer(Properties proxyProps, Properties clientProps) {
 
 Review comment:
   I think combining these two sets of properties maintains a better abstraction between the implementation of the server and the organization of the parameters required to start the server.
   
   Another option would be to pass in the proxy server properties, along with a Connector that has already been constructed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services