[GitHub] [spark] felixcheung commented on a change in pull request #24195: [SPARK-25496][SQL] Deprecate from_utc_timestamp and to_utc_timestamp

[GitBox <gi...@apache.org>]

felixcheung commented on a change in pull request #24195: [SPARK-25496][SQL] Deprecate from_utc_timestamp and to_utc_timestamp
URL: https://github.com/apache/spark/pull/24195#discussion_r269868511
 
 

 ##########
 File path: R/pkg/R/functions.R
 ##########
 @@ -2459,6 +2459,7 @@ setMethod("schema_of_csv", signature(x = "characterOrColumn"),
 #' @note from_utc_timestamp since 1.5.0
 setMethod("from_utc_timestamp", signature(y = "Column", x = "character"),
           function(y, x) {
+            .Deprecated("from_utc_timestamp")
 
 Review comment:
   this is actually, incorrect - https://www.rdocumentation.org/packages/base/versions/3.5.3/topics/Deprecated
   the string is the "new function"  - instead I think you can try `.Deprecated(msg = "from_utc_timestamp is deprecated for xyz reason")`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org