You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/06/07 21:38:28 UTC

[GitHub] [mynewt-newt] jipanienko opened a new pull request #403: Execute .sh scripts with bash on windows

jipanienko opened a new pull request #403:
URL: https://github.com/apache/mynewt-newt/pull/403


   Windows load and debug scripts run .sh scripts with bash starting from windows .cmd script.
   around 100 bsp has same .cmd script with the same text @bash "%~dp0%~n0.sh"
   if newt started .sh file with bash those .cmd scripts can be deleted.
   same command can be used for post build that don't have overwrite as download and debug do.
   
   bash will be hardcoded as /bin/sh is for Linux and NEWT_SH environment can change it to something else if needs to be.
   
   in shorts command lines that start with somthing.sh will be prepend with bash on windows


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-newt] ccollins476ad merged pull request #403: Execute .sh scripts with bash on windows

Posted by GitBox <gi...@apache.org>.
ccollins476ad merged pull request #403:
URL: https://github.com/apache/mynewt-newt/pull/403


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-newt] kasjer commented on pull request #403: Execute .sh scripts with bash on windows

Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #403:
URL: https://github.com/apache/mynewt-newt/pull/403#issuecomment-647754953


   > Thanks @jipanienko, it looks good! I don't have a Windows machine handy to test this on. I assume you tried this and it worked for you?
   
   I use it for pre_build scripts and for download and for debug (.WINDOWS.OVERWRITE removed from bsp)
   It's not breaking anything nobody used .sh on Windows yet.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-newt] jipanienko commented on pull request #403: Execute .sh scripts with bash on windows

Posted by GitBox <gi...@apache.org>.
jipanienko commented on pull request #403:
URL: https://github.com/apache/mynewt-newt/pull/403#issuecomment-647756603


   @kasjer @ccollins476ad tested alrigt 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-newt] ccollins476ad commented on pull request #403: Execute .sh scripts with bash on windows

Posted by GitBox <gi...@apache.org>.
ccollins476ad commented on pull request #403:
URL: https://github.com/apache/mynewt-newt/pull/403#issuecomment-647658607


   Thanks @jipanienko, it looks good!  I don't have a Windows machine handy to test this on.  I assume you tried this and it worked for you?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org