You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2017/01/05 11:15:25 UTC

[GitHub] flink issue #3035: [ FLINK-4905] Kafka test instability IllegalStateExceptio...

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/3035
  
    Thank you for working on this @BrainLogic!
    
    First, regarding the approach proposed here:
    The approach should be able to fix the `IllegalStateException` we're encountering.
    However, I would also want to try to make `ZookeeperOffsetHandler` thread-safe and insensitive to the ordering `commitOffsets` and `close` are called from the outside. Otherwise, from the context of `Kafka08Fetcher` alone, the reason for the new synchronization isn't that obvious, and might result in harder-to-maintain code in the long run. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---