You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Matt Sicker <bo...@gmail.com> on 2014/09/29 16:31:15 UTC

Fwd: git commit: Use a Maven profile to activate FindBugs 3.0.0 only on Java 8.

This could use a profile id like jdk8.
---------- Forwarded message ----------
From: <gg...@apache.org>
Date: 29 September 2014 09:28
Subject: git commit: Use a Maven profile to activate FindBugs 3.0.0 only on
Java 8.
To: commits@logging.apache.org


Repository: logging-log4j2
Updated Branches:
  refs/heads/master 1201fa3d6 -> 630aea837


Use a Maven profile to activate FindBugs 3.0.0 only on Java 8.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit:
http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/630aea83
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/630aea83
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/630aea83

Branch: refs/heads/master
Commit: 630aea83739fed055ccb07f1e50c17f9a7fc0921
Parents: 1201fa3
Author: Gary Gregory <ga...@gmail.com>
Authored: Mon Sep 29 10:28:47 2014 -0400
Committer: Gary Gregory <ga...@gmail.com>
Committed: Mon Sep 29 10:28:47 2014 -0400

----------------------------------------------------------------------
 pom.xml | 8 ++++++++
 1 file changed, 8 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/630aea83/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index e710812..a9024cf 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1275,5 +1275,13 @@
         </plugins>
       </build>
     </profile>
+    <profile>
+      <activation>
+        <jdk>[1.8,)</jdk>
+      </activation>
+      <properties>
+        <findbugs.plugin.version>3.0.0</findbugs.plugin.version>
+      </properties>
+    </profile>
   </profiles>
 </project>




-- 
Matt Sicker <bo...@gmail.com>

Re: git commit: Use a Maven profile to activate FindBugs 3.0.0 only on Java 8.

Posted by Matt Sicker <bo...@gmail.com>.
Nah, profiles all need an ID regardless. The activation element allows
profiles to be automatically activated.

On 29 September 2014 10:40, Gary Gregory <ga...@gmail.com> wrote:

> On Mon, Sep 29, 2014 at 10:31 AM, Matt Sicker <bo...@gmail.com> wrote:
>
>> This could use a profile id like jdk8.
>>
>
> But does that mean that you then need to invoke it specifically with the
> -P option?
>
> Gary
>
>
>>
>> ---------- Forwarded message ----------
>> From: <gg...@apache.org>
>> Date: 29 September 2014 09:28
>> Subject: git commit: Use a Maven profile to activate FindBugs 3.0.0 only
>> on Java 8.
>> To: commits@logging.apache.org
>>
>>
>> Repository: logging-log4j2
>> Updated Branches:
>>   refs/heads/master 1201fa3d6 -> 630aea837
>>
>>
>> Use a Maven profile to activate FindBugs 3.0.0 only on Java 8.
>>
>> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
>> Commit:
>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/630aea83
>> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/630aea83
>> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/630aea83
>>
>> Branch: refs/heads/master
>> Commit: 630aea83739fed055ccb07f1e50c17f9a7fc0921
>> Parents: 1201fa3
>> Author: Gary Gregory <ga...@gmail.com>
>> Authored: Mon Sep 29 10:28:47 2014 -0400
>> Committer: Gary Gregory <ga...@gmail.com>
>> Committed: Mon Sep 29 10:28:47 2014 -0400
>>
>> ----------------------------------------------------------------------
>>  pom.xml | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>> ----------------------------------------------------------------------
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/630aea83/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/pom.xml b/pom.xml
>> index e710812..a9024cf 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -1275,5 +1275,13 @@
>>          </plugins>
>>        </build>
>>      </profile>
>> +    <profile>
>> +      <activation>
>> +        <jdk>[1.8,)</jdk>
>> +      </activation>
>> +      <properties>
>> +        <findbugs.plugin.version>3.0.0</findbugs.plugin.version>
>> +      </properties>
>> +    </profile>
>>    </profiles>
>>  </project>
>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker <bo...@gmail.com>

Re: git commit: Use a Maven profile to activate FindBugs 3.0.0 only on Java 8.

Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Sep 29, 2014 at 10:31 AM, Matt Sicker <bo...@gmail.com> wrote:

> This could use a profile id like jdk8.
>

But does that mean that you then need to invoke it specifically with the -P
option?

Gary


>
> ---------- Forwarded message ----------
> From: <gg...@apache.org>
> Date: 29 September 2014 09:28
> Subject: git commit: Use a Maven profile to activate FindBugs 3.0.0 only
> on Java 8.
> To: commits@logging.apache.org
>
>
> Repository: logging-log4j2
> Updated Branches:
>   refs/heads/master 1201fa3d6 -> 630aea837
>
>
> Use a Maven profile to activate FindBugs 3.0.0 only on Java 8.
>
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/630aea83
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/630aea83
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/630aea83
>
> Branch: refs/heads/master
> Commit: 630aea83739fed055ccb07f1e50c17f9a7fc0921
> Parents: 1201fa3
> Author: Gary Gregory <ga...@gmail.com>
> Authored: Mon Sep 29 10:28:47 2014 -0400
> Committer: Gary Gregory <ga...@gmail.com>
> Committed: Mon Sep 29 10:28:47 2014 -0400
>
> ----------------------------------------------------------------------
>  pom.xml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/630aea83/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index e710812..a9024cf 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -1275,5 +1275,13 @@
>          </plugins>
>        </build>
>      </profile>
> +    <profile>
> +      <activation>
> +        <jdk>[1.8,)</jdk>
> +      </activation>
> +      <properties>
> +        <findbugs.plugin.version>3.0.0</findbugs.plugin.version>
> +      </properties>
> +    </profile>
>    </profiles>
>  </project>
>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory