[GitHub] [flink] gaoyunhaii commented on pull request #18428: [FLINK-25575] Add Sink V2 operators and translation

[GitBox <gi...@apache.org>]

gaoyunhaii commented on pull request #18428:
URL: https://github.com/apache/flink/pull/18428#issuecomment-1024526229


   Very thanks @fapaul for the update and explanation!
   
   For the `execute` method, sorry I has some misunderstandings initially that the clear happens before compile happens, but it should indeed be happen after the generate() is called. However, there seems still cases that the transformation is not cleared, like users call `StreamExecutionEnvironment#getExecutionPlan()` ? 
   
   
   
   For the Batch exchange, I think perhaps with branches (namely pass the runtime mode to SinkExpander and avoid create the failover region for streaming mode), we could avoid creating the batch exchange in advance for streaming mode, thus we won't need to rely on the behavior of the blocking edge under streaming mode~?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org