[GitHub] [pulsar] gaoran10 commented on a diff in pull request #17496: [improve][broker] Improve `retention` endpoint to pure async.

[GitBox <gi...@apache.org>]

gaoran10 commented on code in PR #17496:
URL: https://github.com/apache/pulsar/pull/17496#discussion_r975160499


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -1307,33 +1307,30 @@ protected void internalRemoveBacklogQuota(BacklogQuotaType backlogQuotaType) {
         }
     }
 
-    protected void internalSetRetention(RetentionPolicies retention) {
-        validateRetentionPolicies(retention);
-        validateNamespacePolicyOperation(namespaceName, PolicyName.RETENTION, PolicyOperation.WRITE);
-        validatePoliciesReadOnlyAccess();
-
+    protected CompletableFuture<Void> internalSetRetentionAsync(RetentionPolicies retentionPolicies) {
         try {
-            Policies policies = namespaceResources().getPolicies(namespaceName)
-                    .orElseThrow(() -> new RestException(Status.NOT_FOUND,
-                    "Namespace policies does not exist"));
-            if (!checkQuotas(policies, retention)) {

Review Comment:
   Maybe we can delete this method.



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java:
##########
@@ -1195,12 +1195,16 @@ public void getRetention(@Suspended final AsyncResponse asyncResponse,
                              @PathParam("namespace") String namespace) {
         validateNamespaceName(property, cluster, namespace);
         validateNamespacePolicyOperationAsync(namespaceName, PolicyName.RETENTION, PolicyOperation.READ)
-                .thenCompose(__ -> getNamespacePoliciesAsync(namespaceName))
-                .thenAccept(policies -> asyncResponse.resume(policies.retention_policies))

Review Comment:
   Why need to change this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org