You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Tammo van Lessen (JIRA)" <ji...@apache.org> on 2010/10/11 23:31:33 UTC
[jira] Created: (BUILDR-532) package_as_source does not package
resources
package_as_source does not package resources
--------------------------------------------
Key: BUILDR-532
URL: https://issues.apache.org/jira/browse/BUILDR-532
Project: Buildr
Issue Type: Bug
Components: Packaging
Affects Versions: 1.4.2
Reporter: Tammo van Lessen
Fix For: 1.4.3
package_as_source seems to disregard resources, the resulting .zip file just contains sources.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (BUILDR-532) package_as_source does
not package resources
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920019#action_12920019 ]
Alex Boisvert edited comment on BUILDR-532 at 10/11/10 7:02 PM:
----------------------------------------------------------------
Tammo, I can't seem to find the patch attached to this bug... <hint> <hint> :)
was (Author: boisvert):
Tammo, I can seem to find the patch attached to this bug... <hint> <hint> :)
> package_as_source does not package resources
> --------------------------------------------
>
> Key: BUILDR-532
> URL: https://issues.apache.org/jira/browse/BUILDR-532
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.4.2
> Reporter: Tammo van Lessen
> Fix For: 1.4.3
>
>
> package_as_source seems to disregard resources, the resulting .zip file just contains sources.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-532) package_as_source does not package
resources
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920019#action_12920019 ]
Alex Boisvert commented on BUILDR-532:
--------------------------------------
Tammo, I can seem to find the patch attached to this bug... <hint> <hint> :)
> package_as_source does not package resources
> --------------------------------------------
>
> Key: BUILDR-532
> URL: https://issues.apache.org/jira/browse/BUILDR-532
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.4.2
> Reporter: Tammo van Lessen
> Fix For: 1.4.3
>
>
> package_as_source seems to disregard resources, the resulting .zip file just contains sources.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-532) package_as_source does not package
resources
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-532.
-----------------------------------
Resolution: Fixed
Marking as fixed.
> package_as_source does not package resources
> --------------------------------------------
>
> Key: BUILDR-532
> URL: https://issues.apache.org/jira/browse/BUILDR-532
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.4.2
> Reporter: Tammo van Lessen
> Fix For: 1.4.3
>
> Attachments: 0001-BUILDR-532-package_as_sources-now-also-includes-reso.patch
>
>
> package_as_source seems to disregard resources, the resulting .zip file just contains sources.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-532) package_as_source does not package
resources
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920270#action_12920270 ]
Hudson commented on BUILDR-532:
-------------------------------
Integrated in Buildr-ci-build #150 (See [https://hudson.apache.org/hudson/job/Buildr-ci-build/150/])
BUILDR-532 package_as_source does not package resources (Tammo van Lessen)
> package_as_source does not package resources
> --------------------------------------------
>
> Key: BUILDR-532
> URL: https://issues.apache.org/jira/browse/BUILDR-532
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.4.2
> Reporter: Tammo van Lessen
> Fix For: 1.4.3
>
> Attachments: 0001-BUILDR-532-package_as_sources-now-also-includes-reso.patch
>
>
> package_as_source seems to disregard resources, the resulting .zip file just contains sources.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-532) package_as_source does not package
resources
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920253#action_12920253 ]
Alex Boisvert commented on BUILDR-532:
--------------------------------------
Yes, resources.target is the right one to use since resources may be filtered (e.g. property value substitution, etc.) or enhanced.
Patch applied. Thanks Tammo!
boisvert@smudge:~/svn/buildr-trunk$ svn commit -m "BUILDR-532 package_as_source does not package resources (Tammo van Lessen)"
Sending CHANGELOG
Sending lib/buildr/packaging/package.rb
Sending spec/java/packaging_spec.rb
Transmitting file data ...
Committed revision 1021832.
> package_as_source does not package resources
> --------------------------------------------
>
> Key: BUILDR-532
> URL: https://issues.apache.org/jira/browse/BUILDR-532
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.4.2
> Reporter: Tammo van Lessen
> Fix For: 1.4.3
>
> Attachments: 0001-BUILDR-532-package_as_sources-now-also-includes-reso.patch
>
>
> package_as_source seems to disregard resources, the resulting .zip file just contains sources.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-532) package_as_source does not package
resources
Posted by "Tammo van Lessen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tammo van Lessen updated BUILDR-532:
------------------------------------
Attachment: 0001-BUILDR-532-package_as_sources-now-also-includes-reso.patch
Alex, here you are ;) A question was whether to include resources.source or resources.target. My feeling is that these kind of artifacts should ideally have the same contents as the binary package has, but with source files instead of binaries. The resources should be ideally in the same structure as the binary code will expect them. Thus I decided to use resources.target. Feel free to change that if you think differently.
> package_as_source does not package resources
> --------------------------------------------
>
> Key: BUILDR-532
> URL: https://issues.apache.org/jira/browse/BUILDR-532
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.4.2
> Reporter: Tammo van Lessen
> Fix For: 1.4.3
>
> Attachments: 0001-BUILDR-532-package_as_sources-now-also-includes-reso.patch
>
>
> package_as_source seems to disregard resources, the resulting .zip file just contains sources.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.