[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8101: Add limit as filter option

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #8101: Add limit as filter option
URL: https://github.com/apache/incubator-superset/pull/8101#discussion_r317838264
 
 

 ##########
 File path: superset/assets/src/explore/components/controls/FilterBoxItemControl.jsx
 ##########
 @@ -159,6 +161,17 @@ export default class FilterBoxItemControl extends React.Component {
             />
           }
         />
+        <FormRow
+          label={t('Limit')}
+          tooltip={t('Limit number of results.')}
+          control={
+            <TextControl
+              value={this.state.limit}
+              name="limit"
 
 Review comment:
   `isInt=Ture`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org