[GitHub] tysonnorris opened a new pull request #3941: to address #3918, reuse a container on applicationError

[GitBox <gi...@apache.org>]

tysonnorris opened a new pull request #3941: to address #3918, reuse a container on applicationError
URL: https://github.com/apache/incubator-openwhisk/pull/3941
 
 
   Reuse a container on applicationError (graceful error from action), only during /run (any error during /init still destroys the container)
   
   
   <!--- Provide a concise summary of your changes in the Title -->
   
   ## Description
   In the Future handling of `ContainerProxy.initializeAndRun()`, this adjustment will allow container to NOT be destroyed when applicationError is returned from the /run request.
   
   This affects warm container reuse in the case where an anticipated error should produce an error result, but should have no impact on container reuse (container is still valid to process next activation). 
   Example use case is parameter validation where some sanity check is performed at the start of the action code, and immediately returns `{error: "invalid parameter"}`.
   
   This will
   * NOT affect the API/client results (error is still seen on any error from container)
   * improve container reuse (since preemptively failing based on user input will no longer cause container destruction)
   
   I considered, but did NOT implement, a change to `WhiskActivation` to add a field that indicates /init failure - since I think it can only be detected in activation logs whether the applicationError response was during /init vs /run, and it may be useful for action developers to have easier access to this bit of info. Sone of the code is convoluted to track the distinction between _applicationError on /init_ and _applicationError on /run_ (e.g. `WhiskActivation` becomes`(WhiskActivation, Boolean)`).
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [x] I opened an issue to propose and discuss this change (#3918 )
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services