You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/03/05 01:32:29 UTC

Re: Review Request 30807: DRILL-2012: Flatten fails when we filter by a non-projected column

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30807/
-----------------------------------------------------------

(Updated March 5, 2015, 12:32 a.m.)


Review request for drill, Aman Sinha, Jason Altekruse, and Jinfeng Ni.


Changes
-------

upload a new diff


Bugs: DRILL-2012
    https://issues.apache.org/jira/browse/DRILL-2012


Repository: drill-git


Description
-------

Mainly rewrote visitProject in SplitUpComplexExpressions


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/SplitUpComplexExpressions.java 11b6c43 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/flatten/TestFlatten.java dc37079 
  exec/java-exec/src/test/resources/store/text/sample.json PRE-CREATION 

Diff: https://reviews.apache.org/r/30807/diff/


Testing
-------

Unit, functional, tpch tests passed


Thanks,

Sean Hsuan-Yi Chu


Re: Review Request 30807: DRILL-2012: Flatten fails when we filter by a non-projected column

Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30807/
-----------------------------------------------------------

(Updated March 10, 2015, 12:20 a.m.)


Review request for drill, Aman Sinha, Jason Altekruse, and Jinfeng Ni.


Changes
-------

clean code


Bugs: DRILL-2012
    https://issues.apache.org/jira/browse/DRILL-2012


Repository: drill-git


Description
-------

Mainly rewrote visitProject in SplitUpComplexExpressions


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/SplitUpComplexExpressions.java 11b6c43 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/flatten/TestFlatten.java dc37079 
  exec/java-exec/src/test/resources/store/text/sample.json PRE-CREATION 

Diff: https://reviews.apache.org/r/30807/diff/


Testing
-------

Unit, functional, tpch tests passed


Thanks,

Sean Hsuan-Yi Chu