[GitHub] ottobackwards commented on a change in pull request #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1

[GitBox <gi...@apache.org>]

ottobackwards commented on a change in pull request #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1
URL: https://github.com/apache/metron/pull/1330#discussion_r254287222
 
 

 ##########
 File path: metron-platform/metron-parsing/metron-parsing-storm/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
 ##########
 @@ -326,6 +329,10 @@ protected void handleError(String sensorType, byte[] originalMessage, Tuple tupl
     ErrorUtils.handleError(collector, error);
   }
 
 
 Review comment:
   Why are we hashing here?  This seems like it would be something that would maybe impact performance that we can do another way.  Is there no existing field or type we can use?  Why not just pass the Tuple itself?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services