[GitHub] [iceberg] ggershinsky commented on a diff in pull request #2639: Parquet: Support parquet modular encryption

[GitBox <gi...@apache.org>]

ggershinsky commented on code in PR #2639:
URL: https://github.com/apache/iceberg/pull/2639#discussion_r1071228113


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -231,6 +252,39 @@ private WriteBuilder createContextFunc(
       return this;
     }
 
+    private FileEncryptionProperties createEncryptionProperties(
+        NativeFileCryptoParameters nativeParameters) {
+      Preconditions.checkArgument(nativeParameters != null, "Null native crypto parameters");
+
+      ParquetCipher parquetEncryptionAlgorithm;
+      if (nativeParameters.encryptionAlgorithm() == null) {
+        parquetEncryptionAlgorithm = ParquetCipher.AES_GCM_V1; // default

Review Comment:
   In a previous draft version, we had this configuration, but it is removed for now. Couple of reasons: 
   - currently, there is no significant technical reason to use the other Parquet algorithm (GCM-CTR, it is less secure that pure GCM; and the speed is basically the same in the modern Java versions)
   - one less parameter for an end user to learn and set



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org