You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/04 05:13:02 UTC

[GitHub] [spark] fe2s opened a new pull request, #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

fe2s opened a new pull request, #39381:
URL: https://github.com/apache/spark/pull/39381

   …ore than 18
   
   This is a backport PR for https://github.com/apache/spark/pull/39099
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] fe2s commented on pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

Posted by "fe2s (via GitHub)" <gi...@apache.org>.
fe2s commented on PR #39381:
URL: https://github.com/apache/spark/pull/39381#issuecomment-1414085631

   > I'll merge these if we can get tests to re-run, try retriggering them
   
   I tried retriggering with a new push above, but it didn't help, seems like the tests passed, but it was still 'Queued - Test results' status on this page.
   
   I've just retriggered them again, but now from the github UI. Let's see.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #39381:
URL: https://github.com/apache/spark/pull/39381#issuecomment-1409602431

   Roger that - any chance you can retrigger these tests? they're hung for some reason


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #39381:
URL: https://github.com/apache/spark/pull/39381#issuecomment-1416131305

   I merged to 3.2. The relevant test(s) has/have actually passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #39381:
URL: https://github.com/apache/spark/pull/39381#issuecomment-1413834313

   I'll merge these if we can get tests to re-run, try retriggering them


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] fe2s commented on pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

Posted by "fe2s (via GitHub)" <gi...@apache.org>.
fe2s commented on PR #39381:
URL: https://github.com/apache/spark/pull/39381#issuecomment-1409594093

   > Is there a backport for 3.3. too?
   
   Created https://github.com/apache/spark/pull/39813. Sorry for the delay.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #39381:
URL: https://github.com/apache/spark/pull/39381#issuecomment-1415933924

   I'm confused, it looks like it succeeded if I click through to the results. Maybe it has succeeded? I guess I can assume so


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #39381:
URL: https://github.com/apache/spark/pull/39381#issuecomment-1373442557

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #39381:
URL: https://github.com/apache/spark/pull/39381#issuecomment-1402327013

   Is there a backport for 3.3. too?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] commented on pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39381:
URL: https://github.com/apache/spark/pull/39381#issuecomment-1547042461

   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] closed pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #39381: [SPARK-41554] fix changing of Decimal scale when scale decreased by m…
URL: https://github.com/apache/spark/pull/39381


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org