You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Scott Semyan (JIRA)" <be...@incubator.apache.org> on 2005/05/09 20:27:06 UTC

[jira] Created: (BEEHIVE-625) Fixes to build.xml for PetStore

Fixes to build.xml for PetStore
-------------------------------

         Key: BEEHIVE-625
         URL: http://issues.apache.org/jira/browse/BEEHIVE-625
     Project: Beehive
        Type: Bug
  Components: Samples  
    Versions: V1    
    Reporter: Scott Semyan
 Attachments: diff.txt

When building with the new directory layout for PetStore, I found a few problems. The attached diff file corrects the following:

1) Set derby location via a variable in build.properties
2) Copy the derby.jar into the lib directory only during the deploy-beehive target, not in every build
3) Fix the comment for the deploy-beehive target
4) Add an ensure.derby target to make sure derby is present
5) Add the extra jar files from HTTPUnit to the classpath
6) Remove the copy of jars from petstore/lib since this task is taken care of in #2 above
7) Add debug=true to the javac task in the test.build target so we get line numbers when running the tests
8) Make test.build a dependency of test.run so you can edit a test, then automatically build when you run the test again.
9) Modified README to indicate item #1 above.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (BEEHIVE-625) Fixes to build.xml for PetStore

Posted by "Scott Semyan (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-625?page=all ]

Scott Semyan updated BEEHIVE-625:
---------------------------------

    Attachment: diff.txt

> Fixes to build.xml for PetStore
> -------------------------------
>
>          Key: BEEHIVE-625
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-625
>      Project: Beehive
>         Type: Bug
>   Components: Samples
>     Versions: V1
>     Reporter: Scott Semyan
>  Attachments: diff.txt
>
> When building with the new directory layout for PetStore, I found a few problems. The attached diff file corrects the following:
> 1) Set derby location via a variable in build.properties
> 2) Copy the derby.jar into the lib directory only during the deploy-beehive target, not in every build
> 3) Fix the comment for the deploy-beehive target
> 4) Add an ensure.derby target to make sure derby is present
> 5) Add the extra jar files from HTTPUnit to the classpath
> 6) Remove the copy of jars from petstore/lib since this task is taken care of in #2 above
> 7) Add debug=true to the javac task in the test.build target so we get line numbers when running the tests
> 8) Make test.build a dependency of test.run so you can edit a test, then automatically build when you run the test again.
> 9) Modified README to indicate item #1 above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (BEEHIVE-625) Fixes to build.xml for PetStore

Posted by "Krista Baker (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-625?page=all ]
     
Krista Baker closed BEEHIVE-625:
--------------------------------


Verified that the set of items are all currently  present in the build.xml file for petstore. 

> Fixes to build.xml for PetStore
> -------------------------------
>
>          Key: BEEHIVE-625
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-625
>      Project: Beehive
>         Type: Bug
>   Components: Samples
>     Versions: V1
>     Reporter: Scott Semyan
>     Assignee: Krista Baker
>      Fix For: V1
>  Attachments: diff.txt
>
> When building with the new directory layout for PetStore, I found a few problems. The attached diff file corrects the following:
> 1) Set derby location via a variable in build.properties
> 2) Copy the derby.jar into the lib directory only during the deploy-beehive target, not in every build
> 3) Fix the comment for the deploy-beehive target
> 4) Add an ensure.derby target to make sure derby is present
> 5) Add the extra jar files from HTTPUnit to the classpath
> 6) Remove the copy of jars from petstore/lib since this task is taken care of in #2 above
> 7) Add debug=true to the javac task in the test.build target so we get line numbers when running the tests
> 8) Make test.build a dependency of test.run so you can edit a test, then automatically build when you run the test again.
> 9) Modified README to indicate item #1 above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (BEEHIVE-625) Fixes to build.xml for PetStore

Posted by "Eddie O'Neil (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-625?page=all ]
     
Eddie O'Neil resolved BEEHIVE-625:
----------------------------------

      Assign To: Alejandro Ramirez  (was: Eddie O'Neil)
     Resolution: Fixed
    Fix Version: V1

Fixed with SVN 169348.

> Fixes to build.xml for PetStore
> -------------------------------
>
>          Key: BEEHIVE-625
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-625
>      Project: Beehive
>         Type: Bug
>   Components: Samples
>     Versions: V1
>     Reporter: Scott Semyan
>     Assignee: Alejandro Ramirez
>      Fix For: V1
>  Attachments: diff.txt
>
> When building with the new directory layout for PetStore, I found a few problems. The attached diff file corrects the following:
> 1) Set derby location via a variable in build.properties
> 2) Copy the derby.jar into the lib directory only during the deploy-beehive target, not in every build
> 3) Fix the comment for the deploy-beehive target
> 4) Add an ensure.derby target to make sure derby is present
> 5) Add the extra jar files from HTTPUnit to the classpath
> 6) Remove the copy of jars from petstore/lib since this task is taken care of in #2 above
> 7) Add debug=true to the javac task in the test.build target so we get line numbers when running the tests
> 8) Make test.build a dependency of test.run so you can edit a test, then automatically build when you run the test again.
> 9) Modified README to indicate item #1 above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (BEEHIVE-625) Fixes to build.xml for PetStore

Posted by "Alejandro Ramirez (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-625?page=all ]

Alejandro Ramirez reassigned BEEHIVE-625:
-----------------------------------------

    Assign To: Krista Baker  (was: Alejandro Ramirez)

Please verify

> Fixes to build.xml for PetStore
> -------------------------------
>
>          Key: BEEHIVE-625
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-625
>      Project: Beehive
>         Type: Bug
>   Components: Samples
>     Versions: V1
>     Reporter: Scott Semyan
>     Assignee: Krista Baker
>      Fix For: V1
>  Attachments: diff.txt
>
> When building with the new directory layout for PetStore, I found a few problems. The attached diff file corrects the following:
> 1) Set derby location via a variable in build.properties
> 2) Copy the derby.jar into the lib directory only during the deploy-beehive target, not in every build
> 3) Fix the comment for the deploy-beehive target
> 4) Add an ensure.derby target to make sure derby is present
> 5) Add the extra jar files from HTTPUnit to the classpath
> 6) Remove the copy of jars from petstore/lib since this task is taken care of in #2 above
> 7) Add debug=true to the javac task in the test.build target so we get line numbers when running the tests
> 8) Make test.build a dependency of test.run so you can edit a test, then automatically build when you run the test again.
> 9) Modified README to indicate item #1 above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (BEEHIVE-625) Fixes to build.xml for PetStore

Posted by "Eddie O'Neil (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-625?page=all ]

Eddie O'Neil updated BEEHIVE-625:
---------------------------------

    Assign To: Eddie O'Neil

Scott--Is your sync up to date?  I fixed a bunch of these issues over the weekend including check for derby.jar, copying it only once per "deploy-beehive" call, and adding the HTTPUnit classes to the test classpath.

So, 1, 2, 3, 4, and 5 should already be taken care of.

The next checkin will have 6, 7, and 9.  I'm going to leave the "test.build" and "test.run" targets separate so that the build isn't required for every test run.

Thanks for the fixes!

> Fixes to build.xml for PetStore
> -------------------------------
>
>          Key: BEEHIVE-625
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-625
>      Project: Beehive
>         Type: Bug
>   Components: Samples
>     Versions: V1
>     Reporter: Scott Semyan
>     Assignee: Eddie O'Neil
>  Attachments: diff.txt
>
> When building with the new directory layout for PetStore, I found a few problems. The attached diff file corrects the following:
> 1) Set derby location via a variable in build.properties
> 2) Copy the derby.jar into the lib directory only during the deploy-beehive target, not in every build
> 3) Fix the comment for the deploy-beehive target
> 4) Add an ensure.derby target to make sure derby is present
> 5) Add the extra jar files from HTTPUnit to the classpath
> 6) Remove the copy of jars from petstore/lib since this task is taken care of in #2 above
> 7) Add debug=true to the javac task in the test.build target so we get line numbers when running the tests
> 8) Make test.build a dependency of test.run so you can edit a test, then automatically build when you run the test again.
> 9) Modified README to indicate item #1 above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (BEEHIVE-625) Fixes to build.xml for PetStore

Posted by "Scott Semyan (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-625?page=comments#action_64782 ]
     
Scott Semyan commented on BEEHIVE-625:
--------------------------------------

Sorry, we crossed paths over the weekend. I had meant to log all of this on Friday but didn't get to it until this morning. I then did a full sync and saw your changes.

As to issue #1 above, I find the derby.jar variable confusing. I've logged the following bug on it:
http://issues.apache.org/jira/browse/BEEHIVE-628

Issue #3 does not appear to be fixed. This is just the comment for the target. You have:
<!-- ========================================= -->
<!-- build - build the webapp                  -->
<!-- ========================================= -->

But it should probably be something like:
<!-- =================================================================== -->
<!-- deploy-beehive - deploy the beehive components into the webapp lib  -->
<!-- =================================================================== -->

As to #8 above, I like the idea of always building before running the test. Ant & javac are smart enough that if no files have changed it won't rebuild the classes. It's confusing when you change a test then run and you don't see your changes. But, I'll defer to your decision.

> Fixes to build.xml for PetStore
> -------------------------------
>
>          Key: BEEHIVE-625
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-625
>      Project: Beehive
>         Type: Bug
>   Components: Samples
>     Versions: V1
>     Reporter: Scott Semyan
>     Assignee: Alejandro Ramirez
>      Fix For: V1
>  Attachments: diff.txt
>
> When building with the new directory layout for PetStore, I found a few problems. The attached diff file corrects the following:
> 1) Set derby location via a variable in build.properties
> 2) Copy the derby.jar into the lib directory only during the deploy-beehive target, not in every build
> 3) Fix the comment for the deploy-beehive target
> 4) Add an ensure.derby target to make sure derby is present
> 5) Add the extra jar files from HTTPUnit to the classpath
> 6) Remove the copy of jars from petstore/lib since this task is taken care of in #2 above
> 7) Add debug=true to the javac task in the test.build target so we get line numbers when running the tests
> 8) Make test.build a dependency of test.run so you can edit a test, then automatically build when you run the test again.
> 9) Modified README to indicate item #1 above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira