[jira] [Work logged] (TS-2220) Rename proxy.config.http.anonymize_insert_client_ip to proxy.config.http.insert_client_ip

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-2220?focusedWorklogId=27015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27015 ]

ASF GitHub Bot logged work on TS-2220:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Aug/16 03:21
            Start Date: 24/Aug/16 03:21
    Worklog Time Spent: 10m 
      Work Description: GitHub user bryancall opened a pull request:

    https://github.com/apache/trafficserver/pull/911

    TS-2220: Rename proxy.config.http.anonymize_insert_client_ip

    Rename proxy.config.http.anonymize_insert_client_ip to proxy.config.http.insert_client_ip

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bryancall/trafficserver TS-2220

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/911.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #911
    
----
commit 2132de14190efd8ff35e29f791cbbbd27cd47a94
Author: Bryan Call <bc...@apache.org>
Date:   2016-08-24T03:20:37Z

    TS-2220: Rename proxy.config.http.anonymize_insert_client_ip to proxy.config.http.insert_client_ip

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 27015)
            Time Spent: 10m
    Remaining Estimate: 0h

> Rename proxy.config.http.anonymize_insert_client_ip to proxy.config.http.insert_client_ip
> -----------------------------------------------------------------------------------------
>
>                 Key: TS-2220
>                 URL: https://issues.apache.org/jira/browse/TS-2220
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: HTTP
>    Affects Versions: 4.0.1
>            Reporter: Zhao Yongming
>            Assignee: Bryan Call
>              Labels: incompatible
>             Fix For: 7.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> this is for V4 branch changes, add the new proxy.config.http.insert_client_ip.
> we should name proxy.config.http.anonymize_insert_client_ip as 'proxy.config.http.insert_request_client_ip' or just 'proxy.config.http.insert_client_ip'
> and the current implement of the insert client ip works only if the client request do not have a 'Client-ip' header, but sometimes we need to replace it even if someone send us a fake 'Client-ip':
> proxy.config.http.insert_client_ip
> INT
> 1
> When disabled(0), do nothing.
> When enabled (1), Traffic Server inserts Client-IP headers to retain the client IP address, if there is no such headers. 
> When forced (2), Traffic Server inserts Client-IP, or replace the origin Client-IP header if it is already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)