You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ol...@apache.org on 2012/04/13 21:12:47 UTC
svn commit: r1325908 -
/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Author: olamy
Date: Fri Apr 13 19:12:47 2012
New Revision: 1325908
URL: http://svn.apache.org/viewvc?rev=1325908&view=rev
Log:
document new filtering on context file
Modified:
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java?rev=1325908&r1=1325907&r2=1325908&view=diff
==============================================================================
--- tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java (original)
+++ tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java Fri Apr 13 19:12:47 2012
@@ -305,7 +305,9 @@ public abstract class AbstractRunMojo
/**
- * The path of the Tomcat context XML file.
+ * <p>The path of the Tomcat context XML file.</p>
+ * <p>Prior to release 2.0, the file is filtering as a maven resource so you can use
+ * interpolation tokens ${ }</p>
*
* @parameter expression="${maven.tomcat.contextFile}"
*/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1325908 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Posted by Olivier Lamy <ol...@apache.org>.
2012/4/14 Konstantin Kolinko <kn...@gmail.com>:
> 2012/4/14 Konstantin Kolinko <kn...@gmail.com>:
>> 2012/4/13 <ol...@apache.org>:
>>> Author: olamy
>>> Date: Fri Apr 13 19:12:47 2012
>>> New Revision: 1325908
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1325908&view=rev
>>> Log:
>>> document new filtering on context file
>>>
>>> Modified:
>>> tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
>>>
>>> Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
>>> URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java?rev=1325908&r1=1325907&r2=1325908&view=diff
>>> ==============================================================================
>>> --- tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java (original)
>>> +++ tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java Fri Apr 13 19:12:47 2012
>>> @@ -305,7 +305,9 @@ public abstract class AbstractRunMojo
>>>
>>>
>>> /**
>>> - * The path of the Tomcat context XML file.
>>> + * <p>The path of the Tomcat context XML file.</p>
>>> + * <p>Prior to release 2.0, the file is filtering as a maven resource so you can use
>>> + * interpolation tokens ${ }</p>
>>
>> I do not understand the above wording.
>> You mean that "${ }" can be used starting with 2.0?
>>
>> If yes then the sentence says quite the opposite.
>> It should be s/prior/since/ and s/is filtering/is filtered/.
Glouups thanks for catching the typo from a French native :-)
>>
>> If no then I'd note explicitly that "Since 2.0 you can no longer use ${}".
>>
>
> One more note. In context.xml (as well as in all other XML files
> processed by Tomcat) you can use ${propname} to reference system
> properties.
>
> E.g. I usually create the following file to deploy manager app when
> running with separate CATALINA_HOME and CATALINA_BASE:
>
> <?xml version="1.0" encoding="UTF-8"?>
> <Context docBase="${catalina.home}/webapps/manager"
> antiResourceLocking="false" privileged="true" >
> </Context>
>
> Will such properties expansion in Tomcat stop working because of
> interference from your new feature?
Nope should continue to work .
Only the standard maven filtering is applied here (see
http://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html)
The shared maven component
(http://maven.apache.org/shared/maven-filtering) apply the same
filtering as a standard maven build.
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1325908 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Posted by Konstantin Kolinko <kn...@gmail.com>.
2012/4/14 Konstantin Kolinko <kn...@gmail.com>:
> 2012/4/13 <ol...@apache.org>:
>> Author: olamy
>> Date: Fri Apr 13 19:12:47 2012
>> New Revision: 1325908
>>
>> URL: http://svn.apache.org/viewvc?rev=1325908&view=rev
>> Log:
>> document new filtering on context file
>>
>> Modified:
>> tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
>>
>> Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
>> URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java?rev=1325908&r1=1325907&r2=1325908&view=diff
>> ==============================================================================
>> --- tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java (original)
>> +++ tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java Fri Apr 13 19:12:47 2012
>> @@ -305,7 +305,9 @@ public abstract class AbstractRunMojo
>>
>>
>> /**
>> - * The path of the Tomcat context XML file.
>> + * <p>The path of the Tomcat context XML file.</p>
>> + * <p>Prior to release 2.0, the file is filtering as a maven resource so you can use
>> + * interpolation tokens ${ }</p>
>
> I do not understand the above wording.
> You mean that "${ }" can be used starting with 2.0?
>
> If yes then the sentence says quite the opposite.
> It should be s/prior/since/ and s/is filtering/is filtered/.
>
> If no then I'd note explicitly that "Since 2.0 you can no longer use ${}".
>
One more note. In context.xml (as well as in all other XML files
processed by Tomcat) you can use ${propname} to reference system
properties.
E.g. I usually create the following file to deploy manager app when
running with separate CATALINA_HOME and CATALINA_BASE:
<?xml version="1.0" encoding="UTF-8"?>
<Context docBase="${catalina.home}/webapps/manager"
antiResourceLocking="false" privileged="true" >
</Context>
Will such properties expansion in Tomcat stop working because of
interference from your new feature?
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1325908 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Posted by Konstantin Kolinko <kn...@gmail.com>.
2012/4/13 <ol...@apache.org>:
> Author: olamy
> Date: Fri Apr 13 19:12:47 2012
> New Revision: 1325908
>
> URL: http://svn.apache.org/viewvc?rev=1325908&view=rev
> Log:
> document new filtering on context file
>
> Modified:
> tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
>
> Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
> URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java?rev=1325908&r1=1325907&r2=1325908&view=diff
> ==============================================================================
> --- tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java (original)
> +++ tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java Fri Apr 13 19:12:47 2012
> @@ -305,7 +305,9 @@ public abstract class AbstractRunMojo
>
>
> /**
> - * The path of the Tomcat context XML file.
> + * <p>The path of the Tomcat context XML file.</p>
> + * <p>Prior to release 2.0, the file is filtering as a maven resource so you can use
> + * interpolation tokens ${ }</p>
I do not understand the above wording.
You mean that "${ }" can be used starting with 2.0?
If yes then the sentence says quite the opposite.
It should be s/prior/since/ and s/is filtering/is filtered/.
If no then I'd note explicitly that "Since 2.0 you can no longer use ${}".
> *
> * @parameter expression="${maven.tomcat.contextFile}"
> */
>
>
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org