You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Michael McCandless <lu...@mikemccandless.com> on 2014/05/17 10:32:33 UTC

Re: svn commit: r1595425 - in /lucene/dev/branches/branch_4x: ./ lucene/ lucene/core/ lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java

Grrr, thanks Rob.

Mike McCandless

http://blog.mikemccandless.com


On Sat, May 17, 2014 at 1:22 AM,  <rm...@apache.org> wrote:
> Author: rmuir
> Date: Sat May 17 05:22:33 2014
> New Revision: 1595425
>
> URL: http://svn.apache.org/r1595425
> Log:
> improve test
>
> Modified:
>     lucene/dev/branches/branch_4x/   (props changed)
>     lucene/dev/branches/branch_4x/lucene/   (props changed)
>     lucene/dev/branches/branch_4x/lucene/core/   (props changed)
>     lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java
>
> Modified: lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java
> URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java?rev=1595425&r1=1595424&r2=1595425&view=diff
> ==============================================================================
> --- lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java (original)
> +++ lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java Sat May 17 05:22:33 2014
> @@ -36,6 +36,7 @@ import org.apache.lucene.analysis.MockTo
>  import org.apache.lucene.analysis.Token;
>  import org.apache.lucene.analysis.TokenFilter;
>  import org.apache.lucene.analysis.TokenStream;
> +import org.apache.lucene.analysis.Analyzer.TokenStreamComponents;
>  import org.apache.lucene.document.BinaryDocValuesField;
>  import org.apache.lucene.document.Document;
>  import org.apache.lucene.document.Field;
> @@ -1509,6 +1510,7 @@ public class TestIndexWriterExceptions e
>        String value = null;
>        doc.add(new StoredField("foo", value));
>        iw.addDocument(doc);
> +      fail("didn't get expected exception");
>      } catch (IllegalArgumentException expected) {}
>      iw.close();
>      // make sure we see our good doc
> @@ -1532,6 +1534,7 @@ public class TestIndexWriterExceptions e
>        // set to null value
>        theField.setStringValue(null);
>        iw.addDocument(doc);
> +      fail("didn't get expected exception");
>      } catch (IllegalArgumentException expected) {}
>      iw.close();
>      // make sure we see our good doc
> @@ -1556,6 +1559,7 @@ public class TestIndexWriterExceptions e
>        Field theField = new StoredField("foo", v);
>        doc.add(theField);
>        iw.addDocument(doc);
> +      fail("didn't get expected exception");
>      } catch (NullPointerException expected) {}
>      iw.close();
>      // make sure we see our good doc
> @@ -1580,6 +1584,7 @@ public class TestIndexWriterExceptions e
>        byte v[] = null;
>        theField.setBytesValue(v);
>        iw.addDocument(doc);
> +      fail("didn't get expected exception");
>      } catch (NullPointerException expected) {}
>      iw.close();
>      // make sure we see our good doc
> @@ -1604,6 +1609,7 @@ public class TestIndexWriterExceptions e
>        Field theField = new StoredField("foo", v);
>        doc.add(theField);
>        iw.addDocument(doc);
> +      fail("didn't get expected exception");
>      } catch (IllegalArgumentException expected) {}
>      iw.close();
>      // make sure we see our good doc
> @@ -1628,6 +1634,7 @@ public class TestIndexWriterExceptions e
>        BytesRef v = null;
>        theField.setBytesValue(v);
>        iw.addDocument(doc);
> +      fail("didn't get expected exception");
>      } catch (IllegalArgumentException expected) {}
>      iw.close();
>      // make sure we see our good doc
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: svn commit: r1595425 - in /lucene/dev/branches/branch_4x: ./ lucene/ lucene/core/ lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java

Posted by Robert Muir <rc...@gmail.com>.
it was my bug, i recently added these tests....

On Sat, May 17, 2014 at 4:32 AM, Michael McCandless
<lu...@mikemccandless.com> wrote:
> Grrr, thanks Rob.
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Sat, May 17, 2014 at 1:22 AM,  <rm...@apache.org> wrote:
>> Author: rmuir
>> Date: Sat May 17 05:22:33 2014
>> New Revision: 1595425
>>
>> URL: http://svn.apache.org/r1595425
>> Log:
>> improve test
>>
>> Modified:
>>     lucene/dev/branches/branch_4x/   (props changed)
>>     lucene/dev/branches/branch_4x/lucene/   (props changed)
>>     lucene/dev/branches/branch_4x/lucene/core/   (props changed)
>>     lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java
>>
>> Modified: lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java
>> URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java?rev=1595425&r1=1595424&r2=1595425&view=diff
>> ==============================================================================
>> --- lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java (original)
>> +++ lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java Sat May 17 05:22:33 2014
>> @@ -36,6 +36,7 @@ import org.apache.lucene.analysis.MockTo
>>  import org.apache.lucene.analysis.Token;
>>  import org.apache.lucene.analysis.TokenFilter;
>>  import org.apache.lucene.analysis.TokenStream;
>> +import org.apache.lucene.analysis.Analyzer.TokenStreamComponents;
>>  import org.apache.lucene.document.BinaryDocValuesField;
>>  import org.apache.lucene.document.Document;
>>  import org.apache.lucene.document.Field;
>> @@ -1509,6 +1510,7 @@ public class TestIndexWriterExceptions e
>>        String value = null;
>>        doc.add(new StoredField("foo", value));
>>        iw.addDocument(doc);
>> +      fail("didn't get expected exception");
>>      } catch (IllegalArgumentException expected) {}
>>      iw.close();
>>      // make sure we see our good doc
>> @@ -1532,6 +1534,7 @@ public class TestIndexWriterExceptions e
>>        // set to null value
>>        theField.setStringValue(null);
>>        iw.addDocument(doc);
>> +      fail("didn't get expected exception");
>>      } catch (IllegalArgumentException expected) {}
>>      iw.close();
>>      // make sure we see our good doc
>> @@ -1556,6 +1559,7 @@ public class TestIndexWriterExceptions e
>>        Field theField = new StoredField("foo", v);
>>        doc.add(theField);
>>        iw.addDocument(doc);
>> +      fail("didn't get expected exception");
>>      } catch (NullPointerException expected) {}
>>      iw.close();
>>      // make sure we see our good doc
>> @@ -1580,6 +1584,7 @@ public class TestIndexWriterExceptions e
>>        byte v[] = null;
>>        theField.setBytesValue(v);
>>        iw.addDocument(doc);
>> +      fail("didn't get expected exception");
>>      } catch (NullPointerException expected) {}
>>      iw.close();
>>      // make sure we see our good doc
>> @@ -1604,6 +1609,7 @@ public class TestIndexWriterExceptions e
>>        Field theField = new StoredField("foo", v);
>>        doc.add(theField);
>>        iw.addDocument(doc);
>> +      fail("didn't get expected exception");
>>      } catch (IllegalArgumentException expected) {}
>>      iw.close();
>>      // make sure we see our good doc
>> @@ -1628,6 +1634,7 @@ public class TestIndexWriterExceptions e
>>        BytesRef v = null;
>>        theField.setBytesValue(v);
>>        iw.addDocument(doc);
>> +      fail("didn't get expected exception");
>>      } catch (IllegalArgumentException expected) {}
>>      iw.close();
>>      // make sure we see our good doc
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org