[jira] [Commented] (IGNITE-9256) SQL: make sure that fetched results are cleared from iterator when last element is fetched

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-9256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579815#comment-16579815 ] 

ASF GitHub Bot commented on IGNITE-9256:
----------------------------------------

GitHub user SGrimstad opened a pull request:

    https://github.com/apache/ignite/pull/4540

    IGNITE-9256 Implemented

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite IGNITE-9256

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4540
    
----
commit a357744a4539d245e9eceb743fa526089a9325b8
Author: SGrimstad <sg...@...>
Date:   2018-08-14T13:27:34Z

    IGNITE-9256 Implemented

----


> SQL: make sure that fetched results are cleared from iterator when last element is fetched
> ------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-9256
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9256
>             Project: Ignite
>          Issue Type: Bug
>          Components: sql
>    Affects Versions: 2.6
>            Reporter: Vladimir Ozerov
>            Assignee: Sergey Grimstad
>            Priority: Major
>              Labels: sql-stability
>             Fix For: 2.7
>
>         Attachments: IGNITE-9256__Implemented.patch
>
>
> In practice it is possible for user to forget to nullify Ignite's result set after iteration is finished. Or he may delay cleanup for some reason. 
> The problem is that we hold the whole H2's result set inside our iterator even after all results are delivered to the user. 
> We should forcibly close and then nullify all H2 objects once all results are returned. 
> Key code pieces:
> {{IgniteH2Indexing.executeSqlQueryWithTimer}} - how we get result from H2
> {{H2ResultSetIterator}} - base iterator with H2 objects inside



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)