You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by ss77892 <gi...@git.apache.org> on 2017/08/07 21:32:18 UTC

[GitHub] zeppelin pull request #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow J...

GitHub user ss77892 opened a pull request:

    https://github.com/apache/zeppelin/pull/2520

    ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC specification when…

    … getting the results.
    
    ### What is this PR for?
    
    Fix for ZEPPELIN-2833. JDBC Interpreter uses result set next() method after it's already reached the end. According the JDBC documentation that may cause SQL exception.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    None
    
    ### What is the Jira issue?
    
    https://issues.apache.org/jira/browse/ZEPPELIN-2833
    
    ### How should this be tested?
    
    Use Phoenix 4.7+ select * query for tables that have less than 1000 records. Without patch an exception about closed Result set will be thrown.
    
    ### Questions:
    * Does the licenses files need update?
    No
    * Is there breaking changes for older versions?
    No
    * Does this needs documentation?
    No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ss77892/zeppelin ZEPPELIN-2833

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2520
    
----
commit fa2e6159d79ce56e42ece21e268d37a2f9bc314b
Author: Sergey Soldatov <ss...@apache.org>
Date:   2017-08-04T20:06:36Z

    ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC specification when getting the results.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2520
  
    Will merge this if no more discussion.


---

[GitHub] zeppelin issue #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...

Posted by ss77892 <gi...@git.apache.org>.
Github user ss77892 commented on the issue:

    https://github.com/apache/zeppelin/pull/2520
  
    @felixcheung all the tests that doesn't reach maxCount may be considered as the test that calls resultSet.next() multiple time (if the default jdbc would be Phoenix they would produce this exception) and there is a test testSelectQueryMaxResult that tests that the limit has been reached.


---

[GitHub] zeppelin pull request #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow J...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2520


---

[GitHub] zeppelin issue #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2520
  
    Tested on local (for hive and phoenix) works as expected. LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2520: ZEPPELIN-2833 JDBC Interpreter doesn't follow JDBC spe...

Posted by ss77892 <gi...@git.apache.org>.
Github user ss77892 commented on the issue:

    https://github.com/apache/zeppelin/pull/2520
  
    @felixcheung As I mentioned in the JIRA the default jdbc driver that is used in tests has different behavior ( allows to make call next() even if the result set is already at the end). Not sure how to develop a test in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---