You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/20 13:12:00 UTC

[jira] [Commented] (IGNITE-6454) Data structure suite timeout: test is not able to fail after interruption

    [ https://issues.apache.org/jira/browse/IGNITE-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173151#comment-16173151 ] 

ASF GitHub Bot commented on IGNITE-6454:
----------------------------------------

GitHub user dspavlov opened a pull request:

    https://github.com/apache/ignite/pull/2704

    IGNITE-6454: suite timeout replace to failure

    Interrupted flag check was added

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-6454-interrupt-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2704.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2704
    
----
commit cfe3240a7933894dc3e048d954de524a9061128e
Author: dpavlov <dp...@gridgain.com>
Date:   2017-09-20T13:07:11Z

    IGNITE-6454: suite timeout replace to failure: interrupted flag check was added

----


> Data structure suite timeout: test is not able to fail after interruption
> -------------------------------------------------------------------------
>
>                 Key: IGNITE-6454
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6454
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Dmitriy Pavlov
>            Assignee: Dmitriy Pavlov
>            Priority: Critical
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.3
>
>         Attachments: lastStartedTest_GridCacheReplicatedDataStructuresFailoverSelfTest.testFairReentrantLockConstantMultipleTopologyChangeNonFailoverSafe.log.zip, lastStartedTest_GridCacheReplicatedDataStructuresFailoverSelfTest.testReentrantLockConstantMultipleTopologyChangeNonFailoverSafe.log.zip
>
>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_IgniteDataStrucutures&branch=%3Cdefault%3E&tab=buildTypeStatusDiv
> Most often timeout is caused by following tests:
> GridCacheReplicatedDataStructuresFailoverSelfTest
> - testReentrantLockConstantMultipleTopologyChangeNonFailoverSafe()
> - testFairReentrantLockConstantMultipleTopologyChangeNonFailoverSafe()
> And most of thread dumps contains the following
> {noformat}
> ] :	 [Step 4/5] Thread [name="test-runner-#35143%replicated.GridCacheReplicatedDataStructuresFailoverSelfTest%", id=38586, state=RUNNABLE, blockCnt=0, waitCnt=60]
> [20:34:26] :	 [Step 4/5]         at java.lang.Throwable.fillInStackTrace(Native Method)
> [20:34:26] :	 [Step 4/5]         at java.lang.Throwable.fillInStackTrace(Throwable.java:783)
> [20:34:26] :	 [Step 4/5]         - locked o.a.i.IgniteException@754033e
> [20:34:26] :	 [Step 4/5]         at java.lang.Throwable.<init>(Throwable.java:265)
> [20:34:26] :	 [Step 4/5]         at java.lang.Exception.<init>(Exception.java:66)
> [20:34:26] :	 [Step 4/5]         at java.lang.RuntimeException.<init>(RuntimeException.java:62)
> [20:34:26] :	 [Step 4/5]         at o.a.i.IgniteException.<init>(IgniteException.java:44)
> [20:34:26] :	 [Step 4/5]         at o.a.i.i.processors.datastructures.GridCacheLockImpl$Sync.validate(GridCacheLockImpl.java:275)
> [20:34:26] :	 [Step 4/5]         at o.a.i.i.processors.datastructures.GridCacheLockImpl$Sync.access$1000(GridCacheLockImpl.java:122)
> [20:34:26] :	 [Step 4/5]         at o.a.i.i.processors.datastructures.GridCacheLockImpl.lock(GridCacheLockImpl.java:1200)
> [20:34:26] :	 [Step 4/5]         at o.a.i.i.processors.cache.datastructures.GridCacheAbstractDataStructuresFailoverSelfTest.doTestReentrantLock(GridCacheAbstractDataStructuresFailoverSelfTest.java:785)
> [20:34:26] :	 [Step 4/5]         at o.a.i.i.processors.cache.datastructures.GridCacheAbstractDataStructuresFailoverSelfTest.testFairReentrantLockConstantMultipleTopologyChangeNonFailoverSafe(GridCacheAbstractDataStructuresFailoverSelfTest.java:739)
> [20:34:26] :	 [Step 4/5]         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [20:34:26] :	 [Step 4/5]         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> [20:34:26] :	 [Step 4/5]         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [20:34:26] :	 [Step 4/5]         at java.lang.reflect.Method.invoke(Method.java:606)
> [20:34:26] :	 [Step 4/5]         at junit.framework.TestCase.runTest(TestCase.java:176)
> [20:34:26] :	 [Step 4/5]         at o.a.i.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2000)
> [20:34:26] :	 [Step 4/5]         at o.a.i.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:132)
> [20:34:26] :	 [Step 4/5]         at o.a.i.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:1915)
> [20:34:26] :	 [Step 4/5]         at java.lang.Thread.run(Thread.java:745)
> [20:34:26] :	 [Step 4/5] 
> {noformat}
> That can be indicator that threads are interrupted and flag org.apache.ignite.internal.processors.datastructures.GridCacheLockImpl#interruptAll is set,
> than org.apache.ignite.IgniteException is thrown, but it is ignored by test and test continues to execute



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)