You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by lb...@apache.org on 2020/10/07 21:01:53 UTC

[camel-kafka-connector] 03/04: [core] cleanup CamelSinkTask

This is an automated email from the ASF dual-hosted git repository.

lburgazzoli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git

commit be4ad310200b1a5ec775502277988e94a84e499d
Author: Luca Burgazzoli <lb...@gmail.com>
AuthorDate: Wed Oct 7 17:48:22 2020 +0200

    [core] cleanup CamelSinkTask
---
 .../java/org/apache/camel/kafkaconnector/CamelSinkTask.java    | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkTask.java b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkTask.java
index c39a4f4..3ac39e6 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkTask.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkTask.java
@@ -19,7 +19,6 @@ package org.apache.camel.kafkaconnector;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 
@@ -61,7 +60,7 @@ public class CamelSinkTask extends SinkTask {
 
     @Override
     public String version() {
-        return new CamelSinkConnector().version();
+        return VersionUtil.getVersion();
     }
 
     @Override
@@ -108,7 +107,7 @@ public class CamelSinkTask extends SinkTask {
     }
 
     protected Map<String, String> getDefaultConfig() {
-        return Collections.EMPTY_MAP;
+        return Collections.emptyMap();
     }
 
     protected static String getCamelSinkEndpointConfigPrefix() {
@@ -123,11 +122,10 @@ public class CamelSinkTask extends SinkTask {
     public void put(Collection<SinkRecord> sinkRecords) {
         for (SinkRecord record : sinkRecords) {
             TaskHelper.logRecordContent(LOG, record, config);
-            Map<String, Object> headers = new HashMap<String, Object>();
+            Map<String, Object> headers = new HashMap<>();
             Exchange exchange = new DefaultExchange(producer.getCamelContext());
             headers.put(KAFKA_RECORD_KEY_HEADER, record.key());
-            for (Iterator<Header> iterator = record.headers().iterator(); iterator.hasNext();) {
-                Header header = (Header)iterator.next();
+            for (Header header : record.headers()) {
                 if (header.key().startsWith(HEADER_CAMEL_PREFIX)) {
                     addHeader(headers, header);
                 } else if (header.key().startsWith(PROPERTY_CAMEL_PREFIX)) {