[jira] [Commented] (OFBIZ-5853) The createPartyRole service does not check a duplicate key.

["Supatthra Nawicha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197879#comment-14197879 ] 

Supatthra Nawicha commented on OFBIZ-5853:
------------------------------------------

We use this service call external from OFBiz and do not want to change it. In general it is not a good practice to change a service in compatible with previous version. Please revert your change.

> The createPartyRole service does not check a duplicate key.
> -----------------------------------------------------------
>
>                 Key: OFBIZ-5853
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5853
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Trunk
>            Reporter: Supatthra Nawicha
>            Assignee: Nicolas Malin
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-5853.patch, ofbizbug_CreatePartyroleService.diff
>
>
> The createPartyRole service is changed from minilang to entity-auto which does not check a duplicate key. It effect to the createPartyRelationshipContactAccount service which call the createPartyRole service without check a duplicate key. And it might effect to other code that call the createPartyRole service as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)