You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/01/06 00:28:15 UTC
[kudu-CR] fs: fix cleanup after failure updating data dirs
Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8957
to review the following change.
Change subject: fs: fix cleanup after failure updating data dirs
......................................................................
fs: fix cleanup after failure updating data dirs
The typo here meant that new fs instance files were not being deleted in the
event of an error during the data dir update process. This also prevented
new data dirs from being deleted too, since they weren't empty.
Change-Id: Ic4ec8dc913f9f6dee81a7404b0c0c25f738c9ff1
---
M src/kudu/fs/fs_manager.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/8957/1
--
To view, visit http://gerrit.cloudera.org:8080/8957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4ec8dc913f9f6dee81a7404b0c0c25f738c9ff1
Gerrit-Change-Number: 8957
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] fs: fix cleanup after failure updating data dirs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8957 )
Change subject: fs: fix cleanup after failure updating data dirs
......................................................................
fs: fix cleanup after failure updating data dirs
The typo here meant that new fs instance files were not being deleted in the
event of an error during the data dir update process. This also prevented
new data dirs from being deleted too, since they weren't empty.
Change-Id: Ic4ec8dc913f9f6dee81a7404b0c0c25f738c9ff1
Reviewed-on: http://gerrit.cloudera.org:8080/8957
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/fs/fs_manager.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4ec8dc913f9f6dee81a7404b0c0c25f738c9ff1
Gerrit-Change-Number: 8957
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] fs: fix cleanup after failure updating data dirs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8957 )
Change subject: fs: fix cleanup after failure updating data dirs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4ec8dc913f9f6dee81a7404b0c0c25f738c9ff1
Gerrit-Change-Number: 8957
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 06 Jan 2018 00:32:17 +0000
Gerrit-HasComments: No