You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/05/04 00:40:58 UTC
[GitHub] flink pull request #3817: [FLINK-6428][table] Add support DISTINCT in dataSt...
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3817
[FLINK-6428][table] Add support DISTINCT in dataStream SQL
With the changes of this PR. `DISTINCT` keyword can be supported `SELECT Clause` of dataStream SQL.
In standard database there are two situations can using `DISTINCT` keyword.
* in `SELECT Clause`, e.g.: `SELECT DISTINCT name FROM table`
* in `AGG Clause`, e.g.: `COUNT([ALL|DISTINCT] expression)`,`SUM([ALL|DISTINCT] expression)`, etc.
In this JIRA. we talk about `SELECT Clause`. With the growing elements, the limitations tend to be back-end storage(flink state). In theory, external storage is infinitely large (user can control and expect), this point of view, the infinite STREAM of the DISTINCT can be supported.In addition, external storage, for example: RocksDB, the user can set the TTL according to the actual amount of business data to ensure that external storage is working properly.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-6428][table] Add support DISTINCT in dataStream SQL")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6428-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3817.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3817
----
commit f1aaffd765f05f8b51801ae1bb66426d99480970
Author: sunjincheng121 <su...@gmail.com>
Date: 2017-05-03T03:47:09Z
[FLINK-6428][table] Add support DISTINCT in dataStream SQL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3817: [FLINK-6428][table] Add support DISTINCT in dataStream SQ...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3817
Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3817: [FLINK-6428][table] Add support DISTINCT in dataSt...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 closed the pull request at:
https://github.com/apache/flink/pull/3817
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3817: [FLINK-6428][table] Add support DISTINCT in dataStream SQ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3817
Hi @sunjincheng121, can you close this PR? The feature is already supported (see JIRA). Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---