You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/13 07:23:12 UTC
[GitHub] [beam] pavel-avilov opened a new pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
pavel-avilov opened a new pull request #15714:
URL: https://github.com/apache/beam/pull/15714
Add interface to work with pipelines' cache.
The cache is able to:
- set value by pipelineId and subKey into cache
- set expiration time
- return values by pipelineId and subKey
Additionally, add local cache as an implementation of this interface to test playground locally.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
`ValidatesRunner` compliance status (on master branch)
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon?subject=V1+Streaming">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon?subject=V1+Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon?subject=V2+Streaming">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon?subject=Java+8">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon?subject=Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon?subject=Portable+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/badge/icon?subject=Portable">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon?subject=Structured+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon?subject=ValCont">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Examples testing status on various runners
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon?subject=V1+Java11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
Post-Commit SDK/Transform Integration Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Go</th>
<th>Java</th>
<th>Python</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon?subject=3.6">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon?subject=3.7">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon?subject=3.8">
</a>
</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon?subject=Tests">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon?subject=Lint">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon?subject=Docker">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon?subject=Docs">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pavel-avilov commented on pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on pull request #15714:
URL: https://github.com/apache/beam/pull/15714#issuecomment-942003365
R: @pabloem @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ilya-kozyrev commented on a change in pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
ilya-kozyrev commented on a change in pull request #15714:
URL: https://github.com/apache/beam/pull/15714#discussion_r734573291
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
+ SubKey_Status SubKey = "STATUS"
+ SubKey_RunOutput SubKey = "RUN_OUTPUT"
+ SubKey_CompileOutput SubKey = "COMPILE_OUTPUT"
+)
+
+type Cache interface {
+ // GetValue returns value from cache by pipelineId and subKey.
+ GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error)
+
+ // SetValue adds value to cache by pipelineId and subKey.
Review comment:
Remove implicit functionality from this method. Better to use an explicit way to set expiration time. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pavel-avilov commented on pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on pull request #15714:
URL: https://github.com/apache/beam/pull/15714#issuecomment-942003365
R: @pabloem @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ilya-kozyrev commented on a change in pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
ilya-kozyrev commented on a change in pull request #15714:
URL: https://github.com/apache/beam/pull/15714#discussion_r734566633
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
+ SubKey_Status SubKey = "STATUS"
+ SubKey_RunOutput SubKey = "RUN_OUTPUT"
+ SubKey_CompileOutput SubKey = "COMPILE_OUTPUT"
+)
+
+type Cache interface {
+ // GetValue returns value from cache by pipelineId and subKey.
+ GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error)
+
+ // SetValue adds value to cache by pipelineId and subKey.
Review comment:
Removed auto expiration from setValue. Better to use explicit method setExpTime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ilya-kozyrev commented on a change in pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
ilya-kozyrev commented on a change in pull request #15714:
URL: https://github.com/apache/beam/pull/15714#discussion_r734572092
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
+ SubKey_Status SubKey = "STATUS"
+ SubKey_RunOutput SubKey = "RUN_OUTPUT"
+ SubKey_CompileOutput SubKey = "COMPILE_OUTPUT"
+)
+
+type Cache interface {
Review comment:
Added, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15714:
URL: https://github.com/apache/beam/pull/15714#issuecomment-947180505
looking...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15714:
URL: https://github.com/apache/beam/pull/15714#discussion_r734105577
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
+ SubKey_Status SubKey = "STATUS"
+ SubKey_RunOutput SubKey = "RUN_OUTPUT"
+ SubKey_CompileOutput SubKey = "COMPILE_OUTPUT"
+)
+
+type Cache interface {
Review comment:
we are caching by pipeline ID, right? How/where/when do we calculate a pipeline ID? What does a cache hit / miss look like?
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
+ SubKey_Status SubKey = "STATUS"
+ SubKey_RunOutput SubKey = "RUN_OUTPUT"
+ SubKey_CompileOutput SubKey = "COMPILE_OUTPUT"
+)
+
+type Cache interface {
+ // GetValue returns value from cache by pipelineId and subKey.
+ GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error)
+
+ // SetValue adds value to cache by pipelineId and subKey.
Review comment:
Is SetValue meant to automatically configure an expiration time? I see that in the local cache, SetValue sets an expiration time as well. Can you document what's the expectation from users of the caches?
##########
File path: playground/backend/internal/cache/local_cache.go
##########
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "fmt"
+ "github.com/google/uuid"
+ "sync"
+ "time"
+)
+
+const cleanupInterval = 5 * time.Second
+
+type LocalCache struct {
+ sync.RWMutex
+ cleanupInterval time.Duration
+ items map[uuid.UUID]map[SubKey]interface{}
+ pipelinesExpiration map[uuid.UUID]time.Time
+}
+
+func newLocalCache(ctx context.Context) *LocalCache {
+ items := make(map[uuid.UUID]map[SubKey]interface{})
+ pipelinesExpiration := make(map[uuid.UUID]time.Time)
+ ls := &LocalCache{
+ cleanupInterval: cleanupInterval,
+ items: items,
+ pipelinesExpiration: pipelinesExpiration,
+ }
+
+ go ls.startGC()
+ return ls
+
+}
+
+func (lc *LocalCache) GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error) {
+ lc.RLock()
+ value, found := lc.items[pipelineId][subKey]
+ if !found {
+ lc.RUnlock()
+ return nil, fmt.Errorf("value with pipelineId: %s and subKey: %s not found", pipelineId, subKey)
+ }
+ expTime := lc.pipelinesExpiration[pipelineId]
+ lc.RUnlock()
+
+ if expTime.Before(time.Now()) {
+ lc.Lock()
+ delete(lc.items[pipelineId], subKey)
+ delete(lc.pipelinesExpiration, pipelineId)
+ lc.Unlock()
+ return nil, fmt.Errorf("value with pipelineId: %s and subKey: %s is expired", pipelineId, subKey)
+ }
+
+ return value, nil
+}
+
+func (lc *LocalCache) SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error {
+ lc.Lock()
+ defer lc.Unlock()
+
+ _, ok := lc.items[pipelineId]
+ if !ok {
+ lc.items[pipelineId] = make(map[SubKey]interface{})
+ lc.pipelinesExpiration[pipelineId] = time.Now().Add(time.Hour)
+ }
+ lc.items[pipelineId][subKey] = value
+ return nil
+}
+
+func (lc *LocalCache) SetExpTime(ctx context.Context, pipelineId uuid.UUID, expTime time.Duration) error {
Review comment:
What happens if a user does this?
```
local_cache = new local cache()
local_cache.SetExpTime(ctx, "pipelineA", 1second)
// Now wait one second
```
Would `clearItems` throw an error because it tries to delete the pipeline from `lc.items`, but it's not part of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ilya-kozyrev commented on a change in pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
ilya-kozyrev commented on a change in pull request #15714:
URL: https://github.com/apache/beam/pull/15714#discussion_r734574884
##########
File path: playground/backend/internal/cache/local_cache.go
##########
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "fmt"
+ "github.com/google/uuid"
+ "sync"
+ "time"
+)
+
+const cleanupInterval = 5 * time.Second
+
+type LocalCache struct {
+ sync.RWMutex
+ cleanupInterval time.Duration
+ items map[uuid.UUID]map[SubKey]interface{}
+ pipelinesExpiration map[uuid.UUID]time.Time
+}
+
+func newLocalCache(ctx context.Context) *LocalCache {
+ items := make(map[uuid.UUID]map[SubKey]interface{})
+ pipelinesExpiration := make(map[uuid.UUID]time.Time)
+ ls := &LocalCache{
+ cleanupInterval: cleanupInterval,
+ items: items,
+ pipelinesExpiration: pipelinesExpiration,
+ }
+
+ go ls.startGC()
+ return ls
+
+}
+
+func (lc *LocalCache) GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error) {
+ lc.RLock()
+ value, found := lc.items[pipelineId][subKey]
+ if !found {
+ lc.RUnlock()
+ return nil, fmt.Errorf("value with pipelineId: %s and subKey: %s not found", pipelineId, subKey)
+ }
+ expTime := lc.pipelinesExpiration[pipelineId]
+ lc.RUnlock()
+
+ if expTime.Before(time.Now()) {
+ lc.Lock()
+ delete(lc.items[pipelineId], subKey)
+ delete(lc.pipelinesExpiration, pipelineId)
+ lc.Unlock()
+ return nil, fmt.Errorf("value with pipelineId: %s and subKey: %s is expired", pipelineId, subKey)
+ }
+
+ return value, nil
+}
+
+func (lc *LocalCache) SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error {
+ lc.Lock()
+ defer lc.Unlock()
+
+ _, ok := lc.items[pipelineId]
+ if !ok {
+ lc.items[pipelineId] = make(map[SubKey]interface{})
+ lc.pipelinesExpiration[pipelineId] = time.Now().Add(time.Hour)
+ }
+ lc.items[pipelineId][subKey] = value
+ return nil
+}
+
+func (lc *LocalCache) SetExpTime(ctx context.Context, pipelineId uuid.UUID, expTime time.Duration) error {
Review comment:
We missed this case, thanks! Added Checking key for cache keys now before setting expiration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ilya-kozyrev commented on a change in pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
ilya-kozyrev commented on a change in pull request #15714:
URL: https://github.com/apache/beam/pull/15714#discussion_r734566731
##########
File path: playground/backend/internal/cache/local_cache.go
##########
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "fmt"
+ "github.com/google/uuid"
+ "sync"
+ "time"
+)
+
+const cleanupInterval = 5 * time.Second
+
+type LocalCache struct {
+ sync.RWMutex
+ cleanupInterval time.Duration
+ items map[uuid.UUID]map[SubKey]interface{}
+ pipelinesExpiration map[uuid.UUID]time.Time
+}
+
+func newLocalCache(ctx context.Context) *LocalCache {
+ items := make(map[uuid.UUID]map[SubKey]interface{})
+ pipelinesExpiration := make(map[uuid.UUID]time.Time)
+ ls := &LocalCache{
+ cleanupInterval: cleanupInterval,
+ items: items,
+ pipelinesExpiration: pipelinesExpiration,
+ }
+
+ go ls.startGC()
+ return ls
+
+}
+
+func (lc *LocalCache) GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error) {
+ lc.RLock()
+ value, found := lc.items[pipelineId][subKey]
+ if !found {
+ lc.RUnlock()
+ return nil, fmt.Errorf("value with pipelineId: %s and subKey: %s not found", pipelineId, subKey)
+ }
+ expTime := lc.pipelinesExpiration[pipelineId]
+ lc.RUnlock()
+
+ if expTime.Before(time.Now()) {
+ lc.Lock()
+ delete(lc.items[pipelineId], subKey)
+ delete(lc.pipelinesExpiration, pipelineId)
+ lc.Unlock()
+ return nil, fmt.Errorf("value with pipelineId: %s and subKey: %s is expired", pipelineId, subKey)
+ }
+
+ return value, nil
+}
+
+func (lc *LocalCache) SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error {
+ lc.Lock()
+ defer lc.Unlock()
+
+ _, ok := lc.items[pipelineId]
+ if !ok {
+ lc.items[pipelineId] = make(map[SubKey]interface{})
+ lc.pipelinesExpiration[pipelineId] = time.Now().Add(time.Hour)
+ }
+ lc.items[pipelineId][subKey] = value
+ return nil
+}
+
+func (lc *LocalCache) SetExpTime(ctx context.Context, pipelineId uuid.UUID, expTime time.Duration) error {
Review comment:
added error handling for not presented pipelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #15714:
URL: https://github.com/apache/beam/pull/15714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ilya-kozyrev commented on a change in pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
ilya-kozyrev commented on a change in pull request #15714:
URL: https://github.com/apache/beam/pull/15714#discussion_r734566633
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
+ SubKey_Status SubKey = "STATUS"
+ SubKey_RunOutput SubKey = "RUN_OUTPUT"
+ SubKey_CompileOutput SubKey = "COMPILE_OUTPUT"
+)
+
+type Cache interface {
+ // GetValue returns value from cache by pipelineId and subKey.
+ GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error)
+
+ // SetValue adds value to cache by pipelineId and subKey.
Review comment:
Removed auto expiration from setValue. Better to use explicit method setExpTime
##########
File path: playground/backend/internal/cache/local_cache.go
##########
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "fmt"
+ "github.com/google/uuid"
+ "sync"
+ "time"
+)
+
+const cleanupInterval = 5 * time.Second
+
+type LocalCache struct {
+ sync.RWMutex
+ cleanupInterval time.Duration
+ items map[uuid.UUID]map[SubKey]interface{}
+ pipelinesExpiration map[uuid.UUID]time.Time
+}
+
+func newLocalCache(ctx context.Context) *LocalCache {
+ items := make(map[uuid.UUID]map[SubKey]interface{})
+ pipelinesExpiration := make(map[uuid.UUID]time.Time)
+ ls := &LocalCache{
+ cleanupInterval: cleanupInterval,
+ items: items,
+ pipelinesExpiration: pipelinesExpiration,
+ }
+
+ go ls.startGC()
+ return ls
+
+}
+
+func (lc *LocalCache) GetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey) (interface{}, error) {
+ lc.RLock()
+ value, found := lc.items[pipelineId][subKey]
+ if !found {
+ lc.RUnlock()
+ return nil, fmt.Errorf("value with pipelineId: %s and subKey: %s not found", pipelineId, subKey)
+ }
+ expTime := lc.pipelinesExpiration[pipelineId]
+ lc.RUnlock()
+
+ if expTime.Before(time.Now()) {
+ lc.Lock()
+ delete(lc.items[pipelineId], subKey)
+ delete(lc.pipelinesExpiration, pipelineId)
+ lc.Unlock()
+ return nil, fmt.Errorf("value with pipelineId: %s and subKey: %s is expired", pipelineId, subKey)
+ }
+
+ return value, nil
+}
+
+func (lc *LocalCache) SetValue(ctx context.Context, pipelineId uuid.UUID, subKey SubKey, value interface{}) error {
+ lc.Lock()
+ defer lc.Unlock()
+
+ _, ok := lc.items[pipelineId]
+ if !ok {
+ lc.items[pipelineId] = make(map[SubKey]interface{})
+ lc.pipelinesExpiration[pipelineId] = time.Now().Add(time.Hour)
+ }
+ lc.items[pipelineId][subKey] = value
+ return nil
+}
+
+func (lc *LocalCache) SetExpTime(ctx context.Context, pipelineId uuid.UUID, expTime time.Duration) error {
Review comment:
added error handling for not presented pipelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15714: [BEAM-13005] [Playground] Implement local cache for pipelines' states
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15714:
URL: https://github.com/apache/beam/pull/15714#issuecomment-951185192
I will merge, but - the documentation should be part of the interface, right? Not part of the LocalCache class implementation
e.g. the following comments should be in cache.go, not local_cache.go, right?
TODO(@ilya-kozyrev / @pavel-avilov ) - can you add the documentation on the interface in a follow up change? Thanks!
```
// SetValue puts element to cache.
// If a particular pipelineId does not contain in the cache, SetValue creates a new element for this pipelineId without expiration time.
// Use SetExpTime to set expiration time for cache elements.
// If data for a particular pipelineId is already contained in the cache, SetValue sets or updates the value for the specific subKey.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org