You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by linwen <gi...@git.apache.org> on 2016/01/17 11:50:47 UTC
[GitHub] incubator-hawq pull request: HAWQ-274. Add check for segments' tem...
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/274
HAWQ-274. Add check for segments' temporary directories
1. add two columns in gp_segment_config, failed_tmpdir_num and failed_tmpdir;
2. segments' temporary directory information is loaded in shared memeory;
2. segment's RM process checks and reports failed tmp dir number and path in IMAlive message;
3. master's RM process updates segment's status in catalog table, if failed tmp dir number exceeds
the guc values, this segment is considered as down.
Please review, Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/linwen/incubator-hawq HAWQ_274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #274
----
commit d3892ff3742e9479b0d108bffc7e8316a31cce53
Author: Wen Lin <wl...@pivotal.io>
Date: 2016-01-17T10:46:52Z
HAWQ-274. Add check for segments' temporary directories
1. add two columns in gp_segment_config, failed_tmpdir_num and failed_tmpdir;
2. segments' temporary directory information is loaded in shared memeory;
2. segment's RM process checks and reports failed tmp dir number and path in IMAlive message;
3. master's RM process updates segment's status in catalog table, if failed tmp dir number exceeds
the guc values, this segment is considered as down.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Add check for segments' tem...
Posted by changleicn <gi...@git.apache.org>.
Github user changleicn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/274#discussion_r50082248
--- Diff: src/backend/cdb/cdbtmpdir.c ---
@@ -17,113 +17,288 @@
* under the License.
--- End diff --
looks the "failed_tmpdir" column in gp_segment_configuration does not contain the host name of the failed dir. It would be nice to have host name included to ease the failure diagnosis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Add check for segments' tem...
Posted by cwelton <gi...@git.apache.org>.
Github user cwelton commented on the pull request:
https://github.com/apache/incubator-hawq/pull/274#issuecomment-185327918
This PR has now been open for over 30 days.
I see that HAWQ-274 was marked as resolved, did you simply forget to close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Add check for segments' tem...
Posted by changleicn <gi...@git.apache.org>.
Github user changleicn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/274#discussion_r50082027
--- Diff: src/backend/resourcemanager/resourcemanager_RMSEG.c ---
@@ -151,6 +152,7 @@ int initializeSocketServer_RMSEG(void)
}
#define SEGMENT_HEARTBEAT_INTERVAL (3LL * 1000000LL)
#define SEGMENT_HOSTCHECK_INTERVAL (5LL * 1000000LL)
+#define SEGMENT_TMPDIRCHECK_INTERVAL (10 * 60LL * 1000000LL)
--- End diff --
using three gucs for these three parameters might be better. It will make future tuning and testing work much easier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Add check for segments' tem...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the pull request:
https://github.com/apache/incubator-hawq/pull/274#issuecomment-172721324
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Add check for segments' tem...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/274#issuecomment-172711422
The implementation looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Add check for segments' tem...
Posted by linwen <gi...@git.apache.org>.
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Add check for segments' tem...
Posted by changleicn <gi...@git.apache.org>.
Github user changleicn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/274#discussion_r50082095
--- Diff: src/backend/resourcemanager/resourcemanager_RMSEG.c ---
@@ -151,6 +152,7 @@ int initializeSocketServer_RMSEG(void)
}
#define SEGMENT_HEARTBEAT_INTERVAL (3LL * 1000000LL)
#define SEGMENT_HOSTCHECK_INTERVAL (5LL * 1000000LL)
+#define SEGMENT_TMPDIRCHECK_INTERVAL (10 * 60LL * 1000000LL)
--- End diff --
10mins looks a very long time too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-274. Add check for segments' tem...
Posted by changleicn <gi...@git.apache.org>.
Github user changleicn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/274#discussion_r50082134
--- Diff: src/backend/resourcemanager/resourcemanager_RMSEG.c ---
@@ -60,7 +61,7 @@ int ResManagerMainSegment2ndPhase(void)
*/
initCGroupThreads();
- InitFileAccess();
+ //InitFileAccess();
--- End diff --
this line should be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---