You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/12 21:02:52 UTC

[GitHub] [airflow] robobario opened a new pull request #6807: [AIRFLOW-5463] Use same session to delete and add variable in set

robobario opened a new pull request #6807: [AIRFLOW-5463] Use same session to delete and add variable in set
URL: https://github.com/apache/airflow/pull/6807
 
 
   Why:
   * In our system we had a postgres connection error during Variable.set
   resulting in the variable being deleted. The intention of this change is
   that an error should leave the variable unchanged.
   
   https://issues.apache.org/jira/browse/AIRFLOW-5463
   
   ### Tests
   
   I was unable to see a good way to test this, is there a way to make delete succeed and add error? You could consider it a refactoring since the variable tests continue to pass.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services