You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/07/09 20:17:58 UTC

[GitHub] [storm] srdo commented on pull request #3305: [STORM-3553] Upgrade jQuery from 1.11.1 to 3.5.1

srdo commented on pull request #3305:
URL: https://github.com/apache/storm/pull/3305#issuecomment-656330732


   For fixing the RAT plugin, I'd guess you should update the exclusion list in https://github.com/apache/storm/blob/master/pom.xml#L463 to include the new webapp jquery file.
   
   The license update stuff described at https://github.com/apache/storm/blob/master/DEVELOPER.md#auditing-licenses-for-licensenotice only works for dependencies tracked by Maven.
   
   As this dependency is not being pulled in via Maven, I think there is very little to do. The LICENSE and LICENSE-binary files should be updated (this is already done). JQuery doesn't have a NOTICE file so that's not a concern. I think the current changes are good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org