You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Xu-Wentao (via GitHub)" <gi...@apache.org> on 2023/03/29 10:32:18 UTC
[GitHub] [shardingsphere-on-cloud] Xu-Wentao opened a new pull request, #288: bugfix(pitr): fix storage nodes info struct error, add endtime to bac…
Xu-Wentao opened a new pull request, #288:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/288
…kup file, and fix backup mode ptrack did not work.
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
- fix StorageNode struct, make sure to marshal storage nodes data correctly
- when completed backup task, save endTime to backup file.
- add some test
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Test is required for the feat/fix PR, unless you have a good reason
2. Doc is required for the feat PR
3. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore merged pull request #288: bugfix(pitr): fix storage nodes info struct error, add endtime to bac…
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore merged PR #288:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #288: bugfix(pitr): fix storage nodes info struct error, add endtime to bac…
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #288:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/288#issuecomment-1488362613
## [Codecov](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#288](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eed9c12) into [main](https://codecov.io/gh/apache/shardingsphere-on-cloud/commit/46be6a76c39dbc0160613cf2be9eaedabf6d97b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46be6a7) will **decrease** coverage by `13.20%`.
> The diff coverage is `49.16%`.
```diff
@@ Coverage Diff @@
## main #288 +/- ##
===========================================
- Coverage 62.36% 49.16% -13.20%
===========================================
Files 2 8 +6
Lines 279 840 +561
===========================================
+ Hits 174 413 +239
- Misses 103 359 +256
- Partials 2 68 +66
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pitr/cli/internal/pkg/shardingsphere-proxy.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl0ci9jbGkvaW50ZXJuYWwvcGtnL3NoYXJkaW5nc3BoZXJlLXByb3h5Lmdv) | `0.00% <0.00%> (ø)` | |
| [pitr/cli/internal/pkg/local-storage.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl0ci9jbGkvaW50ZXJuYWwvcGtnL2xvY2FsLXN0b3JhZ2UuZ28=) | `42.24% <42.24%> (ø)` | |
| [pitr/cli/internal/cmd/restore.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl0ci9jbGkvaW50ZXJuYWwvY21kL3Jlc3RvcmUuZ28=) | `44.58% <44.58%> (ø)` | |
| [pitr/cli/internal/cmd/show.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl0ci9jbGkvaW50ZXJuYWwvY21kL3Nob3cuZ28=) | `56.09% <56.09%> (ø)` | |
| [pitr/cli/internal/cmd/backup.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl0ci9jbGkvaW50ZXJuYWwvY21kL2JhY2t1cC5nbw==) | `58.87% <58.87%> (ø)` | |
| [pitr/cli/internal/pkg/agent-server.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl0ci9jbGkvaW50ZXJuYWwvcGtnL2FnZW50LXNlcnZlci5nbw==) | `72.27% <72.27%> (ø)` | |
| [pitr/cli/pkg/gsutil/conn.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl0ci9jbGkvcGtnL2dzdXRpbC9jb25uLmdv) | `76.47% <76.47%> (ø)` | |
| [pitr/cli/pkg/stringutil/rand\_string.go](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl0ci9jbGkvcGtnL3N0cmluZ3V0aWwvcmFuZF9zdHJpbmcuZ28=) | `88.88% <88.88%> (ø)` | |
... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/288/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org