You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/04/18 16:52:17 UTC
[kudu-CR] [Java] Fix Guava transitive dependecies
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10096
Change subject: [Java] Fix Guava transitive dependecies
......................................................................
[Java] Fix Guava transitive dependecies
In Guava 22.0+ the annotations dependencies are no
longer marked as optional. However, if the annotations
are not used at runtime or compile time they are
actually not required.
- Excludes the transitive annotations libraries that are
not marked as optional in version 22.0+
- Add’s Guava where it was used directly but not in the
dependencies
Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-flume-sink/pom.xml
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
7 files changed, 62 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/10096/1
--
To view, visit http://gerrit.cloudera.org:8080/10096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d
Gerrit-Change-Number: 10096
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [Java] Fix Guava transitive dependecies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10096
to look at the new patch set (#4).
Change subject: [Java] Fix Guava transitive dependecies
......................................................................
[Java] Fix Guava transitive dependecies
In Guava 22.0+ the annotations dependencies are no
longer marked as optional. However, if the annotations
are not used at runtime or compile time they are
actually not required.
- Excludes the transitive annotations libraries that are
not marked as optional in version 22.0+
- Adds Guava where it was used directly but not in the
dependencies
Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d
---
M java/build.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/pom.xml
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
8 files changed, 71 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/10096/4
--
To view, visit http://gerrit.cloudera.org:8080/10096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d
Gerrit-Change-Number: 10096
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Fix Guava transitive dependecies
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10096 )
Change subject: [Java] Fix Guava transitive dependecies
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d
Gerrit-Change-Number: 10096
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 16:11:23 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Fix Guava transitive dependecies
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10096 )
Change subject: [Java] Fix Guava transitive dependecies
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10096/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10096/3//COMMIT_MSG@16
PS3, Line 16: d’s
Adds
http://gerrit.cloudera.org:8080/#/c/10096/3/java/kudu-client-tools/build.gradle
File java/kudu-client-tools/build.gradle:
http://gerrit.cloudera.org:8080/#/c/10096/3/java/kudu-client-tools/build.gradle@24
PS3, Line 24: compile(libs.guava) { transitive = false }
Is there a way to factor this out into a common configuration across all submodules? For instance Maven has the dependenciesManagement section that you can put in the parent pom to apply configurations like this to all submodules. I'd suggest doing that for the maven part of this patch as well, except I'm hoping all this work you're putting in is going towards scapping maven anyway, in which case it's not a big deal.
--
To view, visit http://gerrit.cloudera.org:8080/10096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d
Gerrit-Change-Number: 10096
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 19 Apr 2018 16:54:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Fix Guava transitive dependecies
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10096 )
Change subject: [Java] Fix Guava transitive dependecies
......................................................................
Patch Set 2: Code-Review+1
Will defer to Dan.
--
To view, visit http://gerrit.cloudera.org:8080/10096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d
Gerrit-Change-Number: 10096
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 18 Apr 2018 19:25:44 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Fix Guava transitive dependecies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10096 )
Change subject: [Java] Fix Guava transitive dependecies
......................................................................
[Java] Fix Guava transitive dependecies
In Guava 22.0+ the annotations dependencies are no
longer marked as optional. However, if the annotations
are not used at runtime or compile time they are
actually not required.
- Excludes the transitive annotations libraries that are
not marked as optional in version 22.0+
- Adds Guava where it was used directly but not in the
dependencies
Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d
Reviewed-on: http://gerrit.cloudera.org:8080/10096
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M java/build.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/pom.xml
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
8 files changed, 71 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d
Gerrit-Change-Number: 10096
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Fix Guava transitive dependecies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10096 )
Change subject: [Java] Fix Guava transitive dependecies
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10096/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10096/3//COMMIT_MSG@16
PS3, Line 16: d’s
> Adds
Done
http://gerrit.cloudera.org:8080/#/c/10096/3/java/kudu-client-tools/build.gradle
File java/kudu-client-tools/build.gradle:
http://gerrit.cloudera.org:8080/#/c/10096/3/java/kudu-client-tools/build.gradle@24
PS3, Line 24: compile(libs.guava) { transitive = false }
> Is there a way to factor this out into a common configuration across all su
I can't set "transitive = false" globally without a some really hacky/experimental and incubating api usage, but I can explicitly exclude all of the annotations dependencies explicitly globally. It's probably better to be more explicit anyway.
--
To view, visit http://gerrit.cloudera.org:8080/10096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d
Gerrit-Change-Number: 10096
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 21 Apr 2018 15:20:15 +0000
Gerrit-HasComments: Yes