[GitHub] [airflow] MaksYermak opened a new pull request, #23075: Fix timezone display for logs on UI

[GitBox <gi...@apache.org>]

MaksYermak opened a new pull request, #23075:
URL: https://github.com/apache/airflow/pull/23075

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   In this PR I have fixed the bug with logs display in UI. The problem is that our time convertion doesn't work correctly. I will try to describe it below. On server side we create a logs in UTC time. After that on UI JavaScript takes this logs and for each timestamps changes UTC flag to flag which is indicated like serverTimezone. But without time convertion, for example for PDT timezone: 2022-04-13 12:15:00,117+00:00 time in log file, on UI will be changed to 2022-04-13 12:15:00,117−07:00 time. Then another JS code using a correct convert function converts this timestamp to a time with a serverTimezone and in result we will see 2022-04-13, 12:15:00 PDT.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi merged pull request #23075: Fix timezone display for logs on UI

[GitBox <gi...@apache.org>]

bbovenzi merged PR #23075:
URL: https://github.com/apache/airflow/pull/23075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #23075: Fix timezone display for logs on UI

[GitBox <gi...@apache.org>]

github-actions[bot] commented on PR #23075:
URL: https://github.com/apache/airflow/pull/23075#issuecomment-1105353103

   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org