You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/30 16:24:05 UTC
[GitHub] [doris] Kikyou1997 opened a new pull request, #11361: [fix](planner) Fix inconsistent nullability between outputTuple and groupByExpr when executing agg query
Kikyou1997 opened a new pull request, #11361:
URL: https://github.com/apache/doris/pull/11361
# Proposed changes
Issue Number: #11360
## Problem Summary:
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
2. Has unit tests been added:
- [ ] No
3. Has document been added or modified:
- [ ] No
4. Does it need to update dependencies:
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #11361: [fix](planner) Fix inconsistent nullability between outputTuple and groupByExpr when executing agg query
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #11361:
URL: https://github.com/apache/doris/pull/11361#issuecomment-1201312448
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #11361: [fix](planner) Fix inconsistent nullability between outputTuple and groupByExpr when executing agg query
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #11361:
URL: https://github.com/apache/doris/pull/11361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11361: [fix](planner) Fix inconsistent nullability between outputTuple and groupByExpr when executing agg query
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11361:
URL: https://github.com/apache/doris/pull/11361#issuecomment-1200935005
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #11361: [fix](planner) Fix inconsistent nullability between outputTuple and groupByExpr when executing agg query
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on PR #11361:
URL: https://github.com/apache/doris/pull/11361#issuecomment-1200790873
> Could you add a simple regression test case?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11361: [fix](planner) Fix inconsistent nullability between outputTuple and groupByExpr when executing agg query
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #11361:
URL: https://github.com/apache/doris/pull/11361#discussion_r934181722
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AggregateInfo.java:
##########
@@ -464,6 +464,23 @@ public void substitute(ExprSubstitutionMap smap, Analyzer analyzer) {
if (secondPhaseDistinctAggInfo != null) {
secondPhaseDistinctAggInfo.substitute(smap, analyzer);
}
+
+ for (SlotDescriptor slotDesc : getOutputTupleDesc().getSlots()) {
Review Comment:
please add some comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #11361: [fix](planner) Fix inconsistent nullability between outputTuple and groupByExpr when executing agg query
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on code in PR #11361:
URL: https://github.com/apache/doris/pull/11361#discussion_r934207531
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AggregateInfo.java:
##########
@@ -464,6 +464,23 @@ public void substitute(ExprSubstitutionMap smap, Analyzer analyzer) {
if (secondPhaseDistinctAggInfo != null) {
secondPhaseDistinctAggInfo.substitute(smap, analyzer);
}
+
+ for (SlotDescriptor slotDesc : getOutputTupleDesc().getSlots()) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11361: [fix](planner) Fix inconsistent nullability between outputTuple and groupByExpr when executing agg query
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11361:
URL: https://github.com/apache/doris/pull/11361#issuecomment-1200934967
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org